Skip to content

Commit

Permalink
net: bgmac: Return PTR_ERR() for fixed_phy_register()
Browse files Browse the repository at this point in the history
fixed_phy_register() returns -EPROBE_DEFER, -EINVAL and -EBUSY,
etc, in addition to -ENODEV. The best practice is to return
these error codes with PTR_ERR().

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ruan Jinjie authored and davem330 committed Aug 20, 2023
1 parent b22eef6 commit d6499f0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/broadcom/bgmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -1450,7 +1450,7 @@ int bgmac_phy_connect_direct(struct bgmac *bgmac)
phy_dev = fixed_phy_register(PHY_POLL, &fphy_status, NULL);
if (!phy_dev || IS_ERR(phy_dev)) {
dev_err(bgmac->dev, "Failed to register fixed PHY device\n");
return -ENODEV;
return PTR_ERR(phy_dev);
}

err = phy_connect_direct(bgmac->net_dev, phy_dev, bgmac_adjust_link,
Expand Down

0 comments on commit d6499f0

Please sign in to comment.