Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use 8 bit segments #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

contradict
Copy link

ConnectionManager passes through to the underlying MessageRouter.

ConnectionManager passes through to the underlying MessageRouter.
@JohannesKauffmann
Copy link
Collaborator

Hi, looking at this PR, I'm not sure I'd want to integrate this change.

If you need 8 bit segments when using a ConnectionManager for implicit requests, you can already construct a MessageRouter yourself, using the appropriate constructor. Although, it is shorter to type true than make_shared<MessageRouter>(true).

And then there is the question of encapsulation. The option to use 8bit segments is currently passed to and stored in the MessageRouter, but also passed to and stored in a MessageRouterRequest. Adding the option here would add to the maintenance overhead; e.g.: should the option ever be renamed, or should the MessageRouter change it's constructor.

@JohannesKauffmann
Copy link
Collaborator

@Broekman Do you have any strong opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants