feat: add feature flag and test for force-unlock #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our implementation is currently not able to be used with the
force-unlock
command of terraform. The reason is that terraform sends n empty body for the unlock request and we expect the lock info.I added a testcase for this and improved the handling slightly - however there is no clear path to allowing the force-unlock. The lock ID is not even sent by the client - should we just unlock any lock? Unfortunately we cannot send an error message to the client either - so they just see something like
This basically means that we currently do not have any possibility to unlock the state besides manipulating the lock backend directly.
What do you think?
See https://github.com/hashicorp/terraform/blob/main/internal/backend/remote-state/http/client.go#L125-L142 for reference.