Skip to content

Conversation

@rosle
Copy link
Contributor

@rosle rosle commented Apr 12, 2019

What happened

✅ Cleanup gems

✅ Re-group the gems

✅ Fix some errors from running rspec due to configuration changes

Issue #89 - Clean up the default gems

Insight

1. Cleanup gems

Gem removed

  • carrierwave
  • carrierwave-aws
  • chronic
  • font-awesome-sass
  • rails_admin
  • jquery-rails (Removed as we're moving away from jquery now)
  • active_model_serializer (Removed as it's quite old. We're considering to move to another gem like fast_jsonapi or jbuilder.)

Gem changed

  • kaminari ↔️ pagy

Gem added

  • tzinfo-data (This is the default from rails)

2. Re-group the gems

I moved some gems around between development and test. This is the final look. - https://github.com/nimblehq/rails-templates/blob/f7270ff5613c71e118ffdecc0da427647994a882/rails_docker/Gemfile.txt

3. Fix some errors due to deprecated configurations

  1. Capybara.wait_on_first_by_default is now the default behavior since v.3

Screen Shot 2562-04-12 at 12 16 20

Changes - teamcapybara/capybara@b6be01d

  1. Json matcher global config is deprecated

This will resolved issue #68

Screen Shot 2562-04-12 at 12 24 15

Changes - thoughtbot/json_matchers#77
For strict option, it is moved to something else - thoughtbot/json_matchers#91

@rosle rosle added this to the 3.2.0 milestone Apr 12, 2019
@rosle rosle changed the title Chore/cleanup gems Cleanup gems Apr 12, 2019
@rosle rosle changed the title Cleanup gems Cleanup gems - WIP Apr 12, 2019
@rosle rosle force-pushed the chore/cleanup-gems branch from f7270ff to 4e7e067 Compare April 12, 2019 08:44
@rosle rosle force-pushed the chore/cleanup-gems branch from 4e7e067 to ec5fbdd Compare April 12, 2019 08:48
@rosle rosle changed the title Cleanup gems - WIP Cleanup gems Apr 12, 2019
@rosle rosle force-pushed the chore/cleanup-gems branch from 97374d5 to 9082480 Compare April 12, 2019 09:30
Copy link
Contributor

@olivierobert olivierobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💃

@olivierobert olivierobert merged commit fca5e9e into develop Apr 12, 2019
@rosle rosle mentioned this pull request Apr 23, 2019
@svnlto svnlto deleted the chore/cleanup-gems branch May 2, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants