Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gets the nimsuggest path from nimble when nimble has nimdir #200

Merged
merged 4 commits into from
May 29, 2024

Conversation

jmgomez
Copy link
Collaborator

@jmgomez jmgomez commented May 22, 2024

This depends on nim-lang/nimble#1221

This depends on nim-lang/nimble#1221
It also needs to be tested in Win.

While developing this found an issue with the project discovery, it uses `nim dump` but it doesnt seem to end when Nim is a local dep, it takes too long. Will try to speed it up in the nimble side of things
@jmgomez jmgomez marked this pull request as draft May 22, 2024 09:06
@jmgomez jmgomez requested a review from nickysn May 22, 2024 11:15
@jmgomez
Copy link
Collaborator Author

jmgomez commented May 28, 2024

In a following PR will unify the calls to nimble dump and later on cache them as they are unnecessary repeated and can take a lot of time if Nim is used as dependency delaying the startup of the langserver

@jmgomez jmgomez marked this pull request as ready for review May 28, 2024 10:54
@jmgomez jmgomez merged commit 0f4463c into nim-lang:master May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant