A couple of fixes, please let me know how to improve this. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n5m
added a commit
to n5m/Nim
that referenced
this pull request
Jul 11, 2021
# This is the 1st commit message: default last in strutils.find to -1 # This is the commit message nim-lang#2: Revert "default last in strutils.find to -1" This reverts commit 3a99556. # This is the commit message nim-lang#3: add openArray variable of find with SkipTable # This is the commit message nim-lang#4: add find method that accepts an openArray # This is the commit message nim-lang#5: add tests # This is the commit message nim-lang#6: Revert "add find method that accepts an openArray" This reverts commit 2ab5351. # This is the commit message nim-lang#7: Revert "add openArray variable of find with SkipTable" This reverts commit 58159fc.
n5m
added a commit
to n5m/Nim
that referenced
this pull request
Jul 11, 2021
# This is the 1st commit message: default last in strutils.find to -1 # This is the commit message nim-lang#2: Revert "default last in strutils.find to -1" This reverts commit 3a99556. # This is the commit message nim-lang#3: add openArray variable of find with SkipTable # This is the commit message nim-lang#4: add find method that accepts an openArray # This is the commit message nim-lang#5: add tests # This is the commit message nim-lang#6: Revert "add find method that accepts an openArray" This reverts commit 2ab5351. # This is the commit message nim-lang#7: Revert "add openArray variable of find with SkipTable" This reverts commit 58159fc.
n5m
added a commit
to n5m/Nim
that referenced
this pull request
Aug 21, 2021
# This is the 1st commit message: default last in strutils.find to -1 # This is the commit message nim-lang#2: Revert "default last in strutils.find to -1" This reverts commit 3a99556. # This is the commit message nim-lang#3: add openArray variable of find with SkipTable # This is the commit message nim-lang#4: add find method that accepts an openArray # This is the commit message nim-lang#5: add tests # This is the commit message nim-lang#6: Revert "add find method that accepts an openArray" This reverts commit 2ab5351. # This is the commit message nim-lang#7: Revert "add openArray variable of find with SkipTable" This reverts commit 58159fc.
n5m
added a commit
to n5m/Nim
that referenced
this pull request
Jan 5, 2022
# This is the 1st commit message: default last in strutils.find to -1 # This is the commit message nim-lang#2: Revert "default last in strutils.find to -1" This reverts commit 3a99556. # This is the commit message nim-lang#3: add openArray variable of find with SkipTable # This is the commit message nim-lang#4: add find method that accepts an openArray # This is the commit message nim-lang#5: add tests # This is the commit message nim-lang#6: Revert "add find method that accepts an openArray" This reverts commit 2ab5351. # This is the commit message nim-lang#7: Revert "add openArray variable of find with SkipTable" This reverts commit 58159fc.
krux02
pushed a commit
to krux02/Nim
that referenced
this pull request
Jan 11, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.