Remove useless assertion in net.nim #4565
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…far as I can tell. Fixes #4406. Signed-off-by: SunDwarf <sun@veriny.tf>
Member
|
ping @dom96 |
Contributor
|
There is a reason that assert is there, fixing that reason isn't trivial: https://github.com/nim-lang/Nim/pull/4565/files#diff-df7c4ae903eab01bc8c4f64f425b48c3R374. IIRC the problem is that the PSK client callback doesn't have access to the underlying SSL context and giving it access is also not so easy. |
Contributor
|
Fixed via f44486c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't seem to be required; it only causes errors.
Fixes #4406