.byref always optimizes sink call into a bitwise memcopy if =sink is disabled
#24327
+38
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Oct 18, 2024
compiler/injectdestructors.nim
Outdated
| @@ -277,7 +277,8 @@ proc deepAliases(dest, ri: PNode): bool = | |||
| proc genSink(c: var Con; s: var Scope; dest, ri: PNode; flags: set[MoveOrCopyFlag] = {}): PNode = | |||
| if (c.inLoopCond == 0 and (isUnpackedTuple(dest) or IsDecl in flags or | |||
| (isAnalysableFieldAccess(dest, c.owner) and isFirstWrite(dest, c)))) or | |||
| isNoInit(dest) or IsReturn in flags: | |||
| isNoInit(dest) or IsReturn in flags or | |||
| tfByRef in dest.typ.flags: | |||
There was a problem hiding this comment.
I think the logic should be "it's .byref and also has its =sink disabled".
ringabout
changed the title
.byref always optimizes sink call into a bitwise memcopy.byref always optimizes sink call into a bitwise memcopy if =sink is disabled
|
This is still not correct as it can introduce leaks for code like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #75
ref nim-lang/threading#79
Or only when
=sinkis disabled forbyRef