make var/pointer types not match if base type has to be converted
#24130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
narimiran
reviewed
Sep 18, 2024
| @@ -164,8 +162,7 @@ pkg "ssostrings" | |||
| pkg "stew" | |||
| pkg "stint", "nim c stint.nim" | |||
| pkg "strslice" | |||
| pkg "strunicode", "nim c -r --mm:refc src/strunicode.nim", | |||
| preCmd = "nimble install -y normalize@#HEAD; nimble uninstall -y normalize; nimble install -y normalize@#HEAD" | |||
| pkg "strunicode", "nimble uninstall -i -y normalize; nimble install -y normalize@#HEAD; nimble install --depsOnly -y; nim c -r --mm:refc src/strunicode.nim" | |||
There was a problem hiding this comment.
I've asked @nitely to bump normalize's version, in hopes this hack won't be needed anymore.
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Sep 18, 2024
…24130) split again from #24038, fixes status-im/nimbus-eth2#6554 (comment) `var`/pointer types are no longer implicitly convertible to each other if their element types either: * require an int conversion or another conversion operation as long as it's not to `openarray`, * are subtypes with pointer indirection, Previously any conversion below a subrange match would match if the element type wasn't a pointer type, then it would error later in `analyseIfAddressTaken`. Different from #24038 in that the preview define that made subrange matches also fail to match is removed for a simpler diff so that it can be backported. (cherry picked from commit 1660ddf)
metagn
added a commit
to metagn/Nim
that referenced
this pull request
Sep 21, 2024
…im-lang#24130) split again from nim-lang#24038, fixes status-im/nimbus-eth2#6554 (comment) `var`/pointer types are no longer implicitly convertible to each other if their element types either: * require an int conversion or another conversion operation as long as it's not to `openarray`, * are subtypes with pointer indirection, Previously any conversion below a subrange match would match if the element type wasn't a pointer type, then it would error later in `analyseIfAddressTaken`. Different from nim-lang#24038 in that the preview define that made subrange matches also fail to match is removed for a simpler diff so that it can be backported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split again from #24038, fixes status-im/nimbus-eth2#6554 (comment)
var/pointer types are no longer implicitly convertible to each other if their element types either:openarray,Previously any conversion below a subrange match would match if the element type wasn't a pointer type, then it would error later in
analyseIfAddressTaken.Different from #24038 in that the preview define that made subrange matches also fail to match is removed for a simpler diff so that it can be backported.