Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #23945; type checking for whenvm expresssions #23970

Merged
merged 7 commits into from
Aug 20, 2024
Merged

fixes #23945; type checking for whenvm expresssions #23970

merged 7 commits into from
Aug 20, 2024

Conversation

ringabout
Copy link
Member

fixes #23945

ringabout
ringabout commented Aug 16, 2024
View reviewed changes
compiler/semexprs.nim Outdated Show resolved Hide resolved
ringabout added a commit to nim-lang/checksums that referenced this pull request Aug 16, 2024
@ringabout
fixes nimvm branch types
55b7762 
ref nim-lang/Nim#23970
@ringabout ringabout mentioned this pull request Aug 16, 2024
Merged
@ringabout
Copy link
Member Author

pending nim-lang/checksums#16

@ringabout
Copy link
Member Author

Without checking, it causes weird problems when mixing different types

ringabout added a commit to nim-lang/checksums that referenced this pull request Aug 17, 2024
@ringabout
fixes nimvm expression mixing types (#16)
bd9bf4e 
* fixes nimvm branch types

ref nim-lang/Nim#23970

* Apply suggestions from code review
ringabout added a commit that referenced this pull request Aug 17, 2024
@ringabout
bump checksums
a7261f6 
ref nim-lang/checksums#16
ref #23970
@ringabout ringabout mentioned this pull request Aug 17, 2024
Merged
Araq pushed a commit that referenced this pull request Aug 17, 2024
@ringabout
bump checksums (#23975)
0ffc049 
ref nim-lang/checksums#16
ref #23970
@Araq Araq added the merge_when_passes_CI mergeable once green label Aug 17, 2024
ringabout added a commit to ringabout/constantine that referenced this pull request Aug 18, 2024
@ringabout
fixes when nimvm mixing different types
64743a7 
ref nim-lang/Nim#23970
@ringabout ringabout mentioned this pull request Aug 18, 2024
Merged
@ringabout
Copy link
Member Author

ringabout commented Aug 18, 2024 •
edited
Loading

Progress: mratsim/constantine#459
Progress: mratsim/constantine#461

mratsim pushed a commit to mratsim/constantine that referenced this pull request Aug 19, 2024
@ringabout
fixes when nimvm mixing different types (#459)
ac7afb2 
ref nim-lang/Nim#23970
@ringabout ringabout marked this pull request as draft August 19, 2024 12:57
@ringabout ringabout marked this pull request as ready for review August 20, 2024 09:32
@ringabout ringabout merged commit dda638c into devel Aug 20, 2024
18 checks passed
@ringabout ringabout deleted the pr_whenvm_sem branch August 20, 2024 12:41
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from dda638c

Hint: mm: orc; opt: speed; options: -d:release
173485 lines; 8.236s; 654.527MiB peakmem

narimiran pushed a commit that referenced this pull request Sep 13, 2024
@ringabout @narimiran
fixes #23945; type checking for whenvm expresssions (#23970)
bfd4b9b 
fixes #23945

(cherry picked from commit dda638c)
narimiran pushed a commit that referenced this pull request Sep 13, 2024
@ringabout @narimiran
bump checksums (#23975)
8bc8347 
ref nim-lang/checksums#16
ref #23970

(cherry picked from commit 0ffc049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid type in nkWhenStmt
2 participants
@ringabout @Araq