Skip to content

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Mar 25, 2024

workaround #23435

related to #22852

see also #23279

@Araq
Copy link
Member

Araq commented Mar 25, 2024

I don't think a workaround is necessary for this fringe case. We should fix the real underlying bug, of course but this workaround does not pull in its weight.

@ringabout
Copy link
Member Author

ringabout commented Mar 25, 2024

#23279 fixes #23435 as well. It's a bug that result is eliminated improperly when range check should be considered but wasn't

@Araq Araq merged commit 229c125 into devel Apr 18, 2024
@Araq Araq deleted the pr_codegen branch April 18, 2024 19:55
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 229c125

Hint: mm: orc; opt: speed; options: -d:release
178485 lines; 8.353s; 752.426MiB peakmem

ringabout added a commit that referenced this pull request May 27, 2024
ringabout added a commit that referenced this pull request May 27, 2024
ringabout added a commit that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants