Skip to content

fix scoping regression with calls in generic bodies #22115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2023
Merged

fix scoping regression with calls in generic bodies #22115

merged 1 commit into from
Jun 17, 2023

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Jun 17, 2023 •
edited
Loading

Araq
Araq reviewed Jun 17, 2023
View reviewed changes
compiler/semcall.nim
else:
if efDetermineType in flags and c.inGenericContext > 0 and c.matchedConcept == nil:
result = n
result = semGenericStmt(c, n)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What? Why?

@Araq
Copy link
Member

Araq commented Jun 17, 2023

Seems to go into the wrong direction. What commit caused this regression? What else can we do about it?

@metagn
Copy link
Collaborator Author

metagn commented Jun 17, 2023 •
edited
Loading

#22029 caused it, basically a tyFromExpr node that uses a private symbol and is instantiated from another module doesn't find that symbol.

Used semGenericStmt because it solves this scoping issue by resolving the symbol, and is already used here in semtypes for generic proc default values and there's also this use which also calls makeTypeFromExpr but I don't really know what it does.

Don't really know another solution. I guess we could also always use semGenericStmt for range/array/when parameters in generic types but this is a radical change.

@Araq
Copy link
Member

Araq commented Jun 17, 2023

Fine.

@Araq Araq added the merge_when_passes_CI mergeable once green label Jun 17, 2023
@ringabout ringabout merged commit 6d21637 into nim-lang:devel Jun 17, 2023
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 6d21637

Hint: mm: orc; opt: speed; options: -d:release
167989 lines; 8.773s; 611.016MiB peakmem

bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
@metagn @bung87
fix scoping regression with calls in generic bodies (nim-lang#22115)
29cf6cd 
refs nim-lang#22029, refs https://github.com/status-im/nim-libp2p/actions/runs/5263850340/jobs/9514434659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Araq left review comments

Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metagn @Araq @ringabout