clean up onUse, onDef, onDefResolveForward #21835
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onUseandonDefResolveForwardhave been no-ops since #20250, however they were not removed from code as they could serve as some kind of comment. In this PR these are removed entirely sinceonDefResolveForwardis used once andonUseis basically always paired with amarkUsed/incl(s.flags, sfUsed)call. In the case where this is removing too much information though, instead of removing we can replace these with just comments, like# s is used here.The stub definition of
onDefis also moved next to the real definition ofonDefinstead of along withonUseandonDefResolveForward.