Fix #13093 C++ Atomics: operator= is implicitly deleted because the default definition would be ill-formed #21169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bung87
force-pushed
the
fix17982_2
branch
2 times, most recently
from
914f851
to
7a5d9f3
Compare
bung87
changed the title
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
|
It seems to break the devel CI https://github.com/nim-lang/Nim/actions/runs/4022933128/jobs/6913212786 |
ringabout
added a commit
that referenced
this pull request
Jan 27, 2023
Araq
pushed a commit
that referenced
this pull request
Jan 27, 2023
survivorm
pushed a commit
to survivorm/Nim
that referenced
this pull request
Feb 28, 2023
…se the default definition would be ill-formed (nim-lang#21169) * add test * fix nim-lang#17982 Invalid C++ code generation when returning discardable var T * fix nim-lang#13093 * cpp atomic good example * clearify the condition
survivorm
pushed a commit
to survivorm/Nim
that referenced
this pull request
Feb 28, 2023
…ed because the default definition would be ill-formed " (nim-lang#21307) Revert "Fix nim-lang#13093 C++ Atomics: operator= is implicitly deleted because the default definition would be ill-formed (nim-lang#21169)" This reverts commit a7bae91.
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
…se the default definition would be ill-formed (nim-lang#21169) * add test * fix nim-lang#17982 Invalid C++ code generation when returning discardable var T * fix nim-lang#13093 * cpp atomic good example * clearify the condition
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
…ed because the default definition would be ill-formed " (nim-lang#21307) Revert "Fix nim-lang#13093 C++ Atomics: operator= is implicitly deleted because the default definition would be ill-formed (nim-lang#21169)" This reverts commit a7bae91.
bung87
added a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
…se the default definition would be ill-formed (nim-lang#21169) * add test * fix nim-lang#17982 Invalid C++ code generation when returning discardable var T * fix nim-lang#13093 * cpp atomic good example * clearify the condition
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
…ed because the default definition would be ill-formed " (nim-lang#21307) Revert "Fix nim-lang#13093 C++ Atomics: operator= is implicitly deleted because the default definition would be ill-formed (nim-lang#21169)" This reverts commit a7bae91.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #17982 change return type
var StringtoStringworks fine,fix #13093