fixes #20155; repr range with distinct types is broken with ORC #20158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please explain the problem and your solution more. |
|
@ringabout Sorry about this - I accidentally merged this PR. Could you make another one? |
|
Thanks for your hard work on this PR! Hint: mm: orc; threads: on; opt: speed; options: -d:release |
|
@Varriount, sure |
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
…RC (nim-lang#20158) * fixes nim-lang#20155; repr range with distinct types is broken with ORC * skipRanges
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
…n with ORC" (nim-lang#20334) Revert "fixes nim-lang#20155; repr range with distinct types is broken with ORC (nim-lang#20158)" This reverts commit 37b3f62.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20155; I tried my best and had to do some hacks with typetrait support to my knowledge.
template repr*(x: distinct): stringwill match range types with distinct subtypes. To repr the real distinct type, we need to skip the range types, otherwise it causes endless recursion.