Skip to content

Make imports/exports not be a dropdown in sidebar #19907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2022
Merged

Make imports/exports not be a dropdown in sidebar #19907

merged 3 commits into from
Jul 16, 2022

Conversation

ire4ever1190
Copy link
Contributor

Makes Imports and Exports sections not be a dropdown anymore
image
Example here

@ire4ever1190 ire4ever1190 changed the title Fix doc dropdown Make imports/exports not be a dropdown in sidebar Jun 19, 2022
@ire4ever1190
Copy link
Contributor Author

Doesn't look like the failures are related to the PR. Could I get them restarted?

@ringabout
Copy link
Member

ringabout commented Jun 20, 2022 •
edited
Loading

@ire4ever1190 I did it for you.

Could I get them restarted?

You can alway request the Nim team to restart CI. If they miss the messages, you can close and reopen the PR to get CI restarted.

@ire4ever1190
Copy link
Contributor Author

Thanks!
Was going to close/reopen but noticed the contributing guide now mentions to ask instead

@Varriount Varriount merged commit c43a377 into nim-lang:devel Jul 16, 2022
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from c43a377

Hint: mm: orc; threads: on; opt: speed; options: -d:release
163452 lines; 15.603s; 841.156MiB peakmem

FedericoCeratto pushed a commit to FedericoCeratto/Nim that referenced this pull request Jul 30, 2022
@ire4ever1190 @FedericoCeratto
Make imports/exports not be a dropdown in sidebar (nim-lang#19907)
a1ec19b 
* Don't make a section be a dropdown if it has no child links

* - Cleaned up code

- Updated tests

* Document what the 'if' is checking
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@ire4ever1190 @capocasa
Make imports/exports not be a dropdown in sidebar (nim-lang#19907)
4a43745 
* Don't make a section be a dropdown if it has no child links

* - Cleaned up code

- Updated tests

* Document what the 'if' is checking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Varriount Varriount Varriount approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ire4ever1190 @ringabout @Varriount