followup #17777: declaredloc field error msgs now work with generics #18259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
timotheecour
force-pushed
the
pr_follow_17777_errormsg_field_generic
branch
from
81239f9 to
500d50d
Compare
timotheecour
added
the
Ready For Review
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
…enerics (nim-lang#18259) * followup nim-lang#17777: declaredloc field error msgs now work with generics * fix tests * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup #17777: declaredloc field error msgs now work with generics
addresses all the points mentioned in future work of #17777 (comment)
someVar.badField now gives errors like this:
instead of:
when typeof(someVar) is generic
ditto with other cases (see tests)