testament: remove deadcode related to realtimeGC, testC, callCCompiler #18087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep running into testament bugs, so simplifying the code is worthwhile (will also simplify other PRs including upcoming custom megatests PR timotheecour#726)
while writing #18086, i noticed that
callCCompiler
is actually deadcode; this hasn't been run in a while, and there is no need to revive it as there would be better/simpler ways to do it nowadays if ever needed (e.g. running c code from a nim file, etc).the only place where this is called is:
testC r, makeTest("tests/realtimeGC/cmain", cOptions, cat), actionRun
which isn't run unless you call:
XDG_CONFIG_HOME= nim r --lib:lib --stacktrace:on testament/testament.nim r longgc
and this fails since at least nim 1.0 with:
Also there were other issues with that code eg:
c[5 .. ^1]
is too magical (and, well, doesn't work)longgc
is redundant withrealtimeGC
(which I've revived in fix realtimeGC tests; testament: error instead of echo when testament category is empty; #16162 so it runs in CI)"--threads: on"
instead of"--threads:on"
but the main reason for removal is that it doesn't need to be revived, there are better ways if such need arises.
note
see also changes to
specialCategories