fix typo in test name undeclared_routime.nim => undeclared_routine.nim #17861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
timotheecour
added
the
TODO: followup needed
This was referenced Apr 26, 2021
timotheecour
removed
the
TODO: followup needed
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
future work
(both are pre-existing issues)
I've noticed that those files aren't being tested in CI, because they start with u instead of t; these should be renamed to tundeclared_routine in followup work (this likely requires fixing those tests) => fix #17859; rename tests so they run in CI; merge several tests with nim check #17862
we should probably given an error when a test file starts with neither t nor m (as recommended in contributing guide for helper test modules), or at least use a whitelist to avoid future similar issues
(=> reported as bug 14 in misc testament issues #16521)