Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .. warning:: #17320

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Use .. warning:: #17320

merged 1 commit into from
Mar 10, 2021

Conversation

konsumlamm
Copy link
Contributor

No description provided.

@konsumlamm
Copy link
Contributor Author

CI failure seems to be unrelated.

@timotheecour timotheecour merged commit 9819fb2 into nim-lang:devel Mar 10, 2021
@timotheecour
Copy link
Member

timotheecour commented Mar 10, 2021

merging, similar PR was approved and merged before.

future work

for reference CI errors were:

PASS: glob c                                                       ( 8.43 sec)
  PASS: ggplotnim c                                                  (45.66 sec)
  FAIL: gnuplot c
  Test "gnuplot" in category "nimble-packages-1"
  Failure: reInstallFailed
  git clone dvolk/gnuplot.nim pkgstemp/gnuplot
  Cloning into 'pkgstemp/gnuplot'...
  fatal: unable to access 'dvolk/gnuplot.nim': Could not resolve host: github.com
  
  FAIL: hts c
  Test "hts" in category "nimble-packages-1"
  Failure: reInstallFailed
  git clone brentp/hts-nim pkgstemp/hts
  Cloning into 'pkgstemp/hts'...
  fatal: unable to access 'brentp/hts-nim': Could not resolve host: github.com
  

if i type: git clone dvolk/gnuplot.nim on cmdline, I get (expectedly): fatal: repository 'dvolk/gnuplot.nim' does not exist

so there's a bug in testament (it could simply be a bug in how cmd is rendered, but still a bug)

@timotheecour timotheecour added the TODO: followup needed remove tag once fixed or tracked elsewhere label Mar 10, 2021
@a-mr
Copy link
Contributor

a-mr commented Mar 11, 2021

@konsumlamm

consider starting warning from a capital letter, it reads a bit better IMHO:

.. Warning::

Also, for most critical messages like danger or caution it would even make sense to spell it all-capital

.. DANGER::

@ringabout
Copy link
Member

@konsumlamm
Copy link
Contributor Author

@konsumlamm

consider starting warning from a capital letter, it reads a bit better IMHO:

.. Warning::

Also, for most critical messages like danger or caution it would even make sense to spell it all-capital

.. DANGER::

I don't see a reason to not use lowercase letters, when they render as the same message anyway... The leading .. is good enough as indicator IMO.

ringabout pushed a commit to ringabout/Nim that referenced this pull request Mar 22, 2021
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
@konsumlamm konsumlamm deleted the warning branch March 30, 2021 21:46
@metagn metagn removed the TODO: followup needed remove tag once fixed or tracked elsewhere label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants