fix #13491 #17279 runnableExamples now don't get lost in translation #17282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
changed the title
timotheecour
changed the title
timotheecour
added
the
TODO: followup needed
timotheecour
changed the title
timotheecour
force-pushed
the
pr_fix_13491_runnableExamples_invalid
branch
from
db05adc to
704ba68
Compare
5 tasks
timotheecour
removed
the
TODO: followup needed
Araq
reviewed
Mar 8, 2021
| rdoccmd = n1.strVal | ||
|
|
||
| var docComment = newTree(nkCommentStmt) | ||
| let useRenderModule = false |
Member
There was a problem hiding this comment.
So ... there is a bunch of dead code here regarding useRenderModule. Why?
Member
Author
There was a problem hiding this comment.
this would snowball into making renderModule itself deadcode, which opens another can of worms.
How about i defer to another PR removing this deadcode, and decide there whether to also remove renderModule or add some test for it?
timotheecour
added
the
TODO: followup needed
ringabout
pushed a commit
to ringabout/Nim
that referenced
this pull request
Mar 22, 2021
… in translation (nim-lang#17282) * fix nim-lang#13491 runnableExamples rendering * fix a runnableExamples thanks to this bugfix
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
… in translation (nim-lang#17282) * fix nim-lang#13491 runnableExamples rendering * fix a runnableExamples thanks to this bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do: => :and(expr) => expr, producing invalid code #13491This PR fixes all such issues with runnableExamples by avoiding the bugs of
renderModule, but underlying problem inrenderModule(and repr) remains and will need to be fixed; at least it won't affect runnableExamples anymore; these are tracked in #17292.future work
useRenderModuledead code