followup #17001: improve coverage for tests/openarray/topenarray.nim #17006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narimiran
pushed a commit
that referenced
this pull request
Feb 18, 2021
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
…ray.nim (nim-lang#17006) * followup nim-lang#17001: improve coverage for tests/openarray/topenarray.nim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup #17001
note that
toOpenArraywith var param doesn't seem to actually work (ie source data isn't mutated), so it's not clear that #17001 actually improved things (it turned an error into a silent non-mutation) /cc @xflywindmaybe to fix this we'd need
slice(https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/slice) ?EDIT:
slicewon't help, but i have another idea for how to fix this (in my views PR, I need to push latest commits, looks very promising)