Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigInt runnableExamples: octal, binary, hex constructor #16868

Merged
merged 21 commits into from
Jan 30, 2021
Merged

BigInt runnableExamples: octal, binary, hex constructor #16868

merged 21 commits into from
Jan 30, 2021

Conversation

juancarlospaco
Copy link
Collaborator

  • Only runnableExamples.
  • Octal, Binary and Hexadecimal BigInts examples.

@juancarlospaco juancarlospaco changed the title BigInt more runnableExamples BigInt only runnableExamples Jan 29, 2021
lib/std/jsbigints.nim Outdated Show resolved Hide resolved
lib/std/jsbigints.nim Outdated Show resolved Hide resolved
Copy link
Member

@timotheecour timotheecour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nits

@timotheecour timotheecour changed the title BigInt only runnableExamples BigInt runnableExamples: octal, binary, hex constructor Jan 29, 2021
lib/std/jsbigints.nim Outdated Show resolved Hide resolved
Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
@timotheecour timotheecour merged commit b8e8eaa into nim-lang:devel Jan 30, 2021
@timotheecour timotheecour deleted the bigintexamples branch January 30, 2021 01:48
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants