fix hintProcessing dots interference with static:echo and hintCC; add tests for nim secret, add tests for hintProcessing, misc other bug fixes
#16495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
changed the title
nim secret, add tests for hintProcessinghintProcessing dots interfering with static:echo, add tests for nim secret, add tests for hintProcessing
timotheecour
changed the title
hintProcessing dots interfering with static:echo, add tests for nim secret, add tests for hintProcessinghintProcessing dots interfering with static:echo, hintCC; add tests for nim secret, add tests for hintProcessing, other hint fixes
timotheecour
changed the title
hintProcessing dots interfering with static:echo, hintCC; add tests for nim secret, add tests for hintProcessing, other hint fixeshintProcessing dots interference with static:echo and hintCC; add tests for nim secret, add tests for hintProcessing, misc other bug fixes
…th linenoise and rdstdin
timotheecour
force-pushed
the
pr_fix_dot_static_echo
branch
from
0e07ebf to
d341b85
Compare
ringabout
reviewed
Dec 29, 2020
Member
|
I'm sorry for the dots in Nim's output. Should we remove them again? |
Member
Author
the feature is good as a default (most bugs have been fixed by now), but in future I'd like the following:
I often find this useful when debugging |
This was referenced Dec 30, 2020
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
…`; add tests for `nim secret`, add tests for hintProcessing, misc other bug fixes (nim-lang#16495) * fix dots interfering with static:echo * add tests * fix hintProcessing dots for hintCC * improve trunner tests * fix bug: readLineFromStdin now writes prompt to stdout, consistent with linenoise and rdstdin * disable a failing test for windows
This was referenced Jan 13, 2021
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
…`; add tests for `nim secret`, add tests for hintProcessing, misc other bug fixes (nim-lang#16495) * fix dots interfering with static:echo * add tests * fix hintProcessing dots for hintCC * improve trunner tests * fix bug: readLineFromStdin now writes prompt to stdout, consistent with linenoise and rdstdin * disable a failing test for windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nim secretdots interfering with prompt #16491 (comment)hintProcessingdots interfering withstatic: echothe logic in PR now also works with
--stdout(see tests)fix
hintProcessingdots interfering with hintCC (CC: ....)add basic tests for
nim secretrefs minor improvement for nim secret #16478 (comment)adds tests for
hintProcessingin particular the fact that dots (after this PR) don't interfere with for examplestatic: echomake trunner warning free
--hint:processingis now overridable, like other hints (eg --hint:link:off ... --hint:linkwould end up with--hint:link`; this is useful when assembling cmdlines, in fact i hit this bug while writing a test in trunner)fix bug:
readLineFromStdinfallback now writes prompt to stdout, consistent with linenoise and rdstdinfuture work
nim r --hint:processing -f --eval:"static: echo 1+1”now works without dot interference when running in cmd.exe, but still fails if shelling out viaexecCmdEx(refs hintProcessing dot interference issue on windows ringabout/Nim#15 problem 4)