Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parseFloatThousandSep #15421

Closed
wants to merge 86 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
1ecf6ed
Add parseFloatThousandSep
juancarlospaco Sep 28, 2020
817df69
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Sep 29, 2020
0b79ec4
https://github.com/nim-lang/Nim/pull/15421#issuecomment-700791178
juancarlospaco Sep 29, 2020
53c3e18
https://github.com/nim-lang/Nim/pull/15421#issuecomment-700791178
juancarlospaco Sep 29, 2020
b3ada57
https://github.com/nim-lang/Nim/pull/15421#issuecomment-700791178
juancarlospaco Sep 29, 2020
ec57030
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Oct 5, 2020
d63112c
feedback
juancarlospaco Oct 5, 2020
590702a
feedbacks
juancarlospaco Oct 5, 2020
2163a46
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Oct 8, 2020
5b2b630
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Oct 15, 2020
af6821a
https://github.com/nim-lang/Nim/pull/15421#discussion_r505507037
juancarlospaco Oct 15, 2020
d1c768e
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 12, 2020
237aeef
Merge branch 'float-thousands-separators' of https://github.com/juanc…
juancarlospaco Nov 12, 2020
af078ea
https://github.com/nim-lang/Nim/pull/15421#discussion_r522453389
juancarlospaco Nov 12, 2020
923663d
https://github.com/nim-lang/Nim/pull/15421#discussion_r522453304
juancarlospaco Nov 12, 2020
32d68e9
Remove unlikely
juancarlospaco Nov 12, 2020
d2bb63f
Fix Changelog conflicts
juancarlospaco Nov 12, 2020
6547469
https://github.com/nim-lang/Nim/pull/15421#discussion_r522454607
juancarlospaco Nov 12, 2020
bf88002
Delete half runnableExamples
juancarlospaco Nov 13, 2020
2d2f558
Move half runnableExamples to testament
juancarlospaco Nov 13, 2020
a02f7e1
clean out
juancarlospaco Nov 13, 2020
3901c56
https://github.com/nim-lang/Nim/pull/15421#discussion_r522517532
juancarlospaco Nov 13, 2020
4c58bdd
Add raise test
juancarlospaco Nov 13, 2020
e19a15c
See also to func not to module
juancarlospaco Nov 13, 2020
b8310c3
See also to func not to module
juancarlospaco Nov 13, 2020
48828f5
Improve a test
juancarlospaco Nov 13, 2020
a98907b
raise proc
juancarlospaco Nov 13, 2020
e1e43fc
improve the improvements
juancarlospaco Nov 13, 2020
ce8c591
improve the improvements
juancarlospaco Nov 13, 2020
842532d
improve the improvements
juancarlospaco Nov 13, 2020
0d2ac4d
the noinline thingy
juancarlospaco Nov 13, 2020
c754556
char repr
juancarlospaco Nov 13, 2020
c3f56ed
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 13, 2020
c151058
https://github.com/nim-lang/Nim/pull/15421#discussion_r522586680
juancarlospaco Nov 13, 2020
a18df8a
https://github.com/nim-lang/Nim/pull/15421#discussion_r522587122
juancarlospaco Nov 13, 2020
64a306f
https://github.com/nim-lang/Nim/pull/15421#discussion_r522587122
juancarlospaco Nov 13, 2020
f5314a1
https://github.com/nim-lang/Nim/pull/15421#discussion_r522587122
juancarlospaco Nov 13, 2020
fce794c
https://github.com/nim-lang/Nim/pull/15421#discussion_r522636227
juancarlospaco Nov 13, 2020
765b6da
https://github.com/nim-lang/Nim/pull/15421#discussion_r522636227
juancarlospaco Nov 13, 2020
7c6c941
https://github.com/nim-lang/Nim/pull/15421#discussion_r522636227
juancarlospaco Nov 13, 2020
d37375e
https://github.com/nim-lang/Nim/pull/15421#discussion_r522636227
juancarlospaco Nov 13, 2020
f8886ba
Add 1 assert to test
juancarlospaco Nov 13, 2020
744355f
Add 1 assert to test
juancarlospaco Nov 13, 2020
a14b96d
https://github.com/nim-lang/Nim/pull/15421#discussion_r522671941
juancarlospaco Nov 13, 2020
4ec5d07
Add a comment
juancarlospaco Nov 13, 2020
7411586
Remove confusing doc line
juancarlospaco Nov 13, 2020
c8f210d
https://github.com/nim-lang/Nim/pull/15421#discussion_r522678760
juancarlospaco Nov 13, 2020
2ab6f83
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 17, 2020
38b26f1
https://github.com/nim-lang/Nim/pull/15421#discussion_r522841456
juancarlospaco Nov 17, 2020
6a38d57
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 17, 2020
eca6572
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 18, 2020
82a49c3
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 18, 2020
5e55e92
refactor and more tests
juancarlospaco Nov 18, 2020
412c652
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 18, 2020
2a95434
Resync devel
juancarlospaco Nov 18, 2020
e181640
Clean
juancarlospaco Nov 19, 2020
b272708
Clean
juancarlospaco Nov 19, 2020
cd9e3b6
Clean
juancarlospaco Nov 19, 2020
41876f2
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 19, 2020
bbfe1b8
Simplify
juancarlospaco Nov 19, 2020
bf6cf49
Simplify
juancarlospaco Nov 19, 2020
d11359a
Allow {pfLeadingDot,pfTrailingDot}
juancarlospaco Nov 19, 2020
3766512
Allow {pfLeadingDot,pfTrailingDot}
juancarlospaco Nov 19, 2020
4bad51a
https://github.com/nim-lang/Nim/pull/15421#discussion_r526731954
juancarlospaco Nov 19, 2020
18fd3c6
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 20, 2020
4619329
Merge branch 'float-thousands-separators' of https://github.com/juanc…
juancarlospaco Nov 20, 2020
32ae2e5
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 23, 2020
68a8228
https://github.com/nim-lang/Nim/pull/15421/files#r526547810
juancarlospaco Nov 23, 2020
4f3b1ee
peer review feedbacks
juancarlospaco Nov 24, 2020
6dd41c9
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 24, 2020
e90786f
1.0e9
juancarlospaco Nov 24, 2020
87ca6ae
1.0e9
juancarlospaco Nov 24, 2020
bdfc4f5
1.0e9
juancarlospaco Nov 24, 2020
7ef7138
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 24, 2020
2114087
NaN
juancarlospaco Nov 24, 2020
5558fac
ReSync devel
juancarlospaco Nov 24, 2020
cc24825
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 24, 2020
15d832b
is always scientific
juancarlospaco Nov 24, 2020
4769a90
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 24, 2020
12854c1
https://github.com/nim-lang/Nim/pull/15421#discussion_r529793041
juancarlospaco Nov 24, 2020
d747b18
Clean out
juancarlospaco Nov 24, 2020
093b826
moar test
juancarlospaco Nov 24, 2020
c61993e
sep and dot must not be '+', 'e', 'i', 'n', 'f', 'a'
juancarlospaco Nov 24, 2020
8040f52
sep and dot must not be '+', 'e', 'i', 'n', 'f', 'a'
juancarlospaco Nov 24, 2020
92b2ae6
Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th…
juancarlospaco Nov 29, 2020
fcc5c35
We need doAssert that takes varargs for tests
juancarlospaco Nov 29, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
sep and dot must not be '+', 'e', 'i', 'n', 'f', 'a'
  • Loading branch information
juancarlospaco committed Nov 24, 2020
commit 8040f52c6b3f90cc7d8954469146e6c310db8ccf
7 changes: 4 additions & 3 deletions lib/pure/strmisc.nim
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,11 @@ since (1, 5):
## consequently `parseFloatThousandSep` by design is slower than `parseFloat`.
##
## The following assumptions and requirements must be met:
## - `sep` must not be `'-'`.
## - `decimalDot` must not be `'-'` nor `' '`.
## - `sep` and `decimalDot` must be different.
## - `str` must not be empty string.
## - `str` must be stripped of trailing and leading whitespaces.
## - `sep` and `decimalDot` must be different.
## - `sep` must not be in `{'-', '+', 'e', 'i', 'n', 'f', 'a', '\n'}`.
## - `decimalDot` must not be in `{'-', '+', 'e', 'i', 'n', 'f', 'a', ' ', '\t', '\v', '\c', '\n', '\f'}`.
##
## See also:
## * `parseFloat <strutils.html#parseFloat,string>`_
Expand Down