fix #14179, fix #14142, make CI 1.4x faster (2x faster locally) #14658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
changed the title
timotheecour
changed the title
Clyybber
reviewed
Jun 14, 2020
Araq
reviewed
Jun 14, 2020
This reverts commit 3d2459b.
nim-lang#12860)" This reverts commit d38853c.
…dirExists/existsFile/fileExists/findExe in config.nims
timotheecour
force-pushed
the
pr_fix_14179_nim_dump_slow2
branch
from
899fa9c to
5ea332b
Compare
|
@Araq PTAL, the last commit should address all your concerns (and also provide less misleading error msgs with nim js). |
|
Thank you, superb work now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make CI significantly faster (1.4x faster on CI machines, 2x locally)
by avoiding
import os(and all the modules that it imports recursively) for every single invocation ofnim; like wise for short-lived commands (egnim dumpornim c smallfileorinim)fix
nim dumpis roughly 100x slower in 1.3 versus 1.2 #14179fix import os + use of existsDir/dirExists/existsFile/fileExists/findExe in config.nims causes "ambiguous call' error #14142
supersedes [superseded] fix #14142: no more clash with: import os + use of existsDir/dirExists/existsFile/fileExists/findExe in config.nims #14143
still keeps import os + use of paramCount and paramStr in config.nims causes "ambiguous call' error #12835 as fixed
see #14179 (comment) for the full context
CI timings on CI machines
before PR => after PR
Linux_amd64 31m => 21m
Linux_i386 32m => 18m
OSX_amd64 17m => 13m
OSX_amd64_cpp 18m => 13m
Windows_amd64 38m => 33m
CI timings locally on OSX
via
XDG_CONFIG_HOME= nim c -r testament/testament all494s => 253s
(didn't try
./koch runCIlocally in this experiment)