Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #14314 do not analyze importc procs for effects #14319

Merged
merged 1 commit into from
May 12, 2020

Conversation

timotheecour
Copy link
Member

fix #14314

@timotheecour timotheecour force-pushed the pr_fix_14314_ProveInit_importcpp branch from 7143459 to 31bd401 Compare May 12, 2020 12:42
@Araq Araq merged commit de74362 into nim-lang:devel May 12, 2020
@timotheecour timotheecour deleted the pr_fix_14314_ProveInit_importcpp branch May 12, 2020 14:22
@kaushalmodi
Copy link
Contributor

@timotheecour This fix works beautifully! The std_vector tests seem to be sped up even more after this, may be because now it is not throwing the ProveInit warning for each importcpp proc.

@timotheecour
Copy link
Member Author

timotheecour commented May 12, 2020

good to hear!

The std_vector tests seem to be sped up

I did not expect that, can you double check with some benchmark? If merely issuing warnings has a measurable performance impact on compile times, we have a bigger problem lol

@kaushalmodi
Copy link
Contributor

As I said "The std_vector tests seem to be sped up". I measured and there's not much noticeable difference. May be lesser noise on the stdout is giving a feeling that the tests ended sooner. Based on the CPU load, it takes 6-8 seconds to finish nim test on the std_vector repo.

EchoPouet pushed a commit to EchoPouet/Nim that referenced this pull request Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting "Warning: Cannot prove that 'result' is initialized" for an importcpp'd proc with var T return type
4 participants