Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --lean compiler flag; improve error message when strutils.% or addf throws by showing all useful context #14282

Closed
wants to merge 9 commits into from
Closed

add --lean compiler flag; improve error message when strutils.% or addf throws by showing all useful context #14282

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
edf5840
improve errmsg in strutils.addf
timotheecour May 9, 2020
e3b18eb
improve error message when addf throws by showing all useful context
timotheecour May 9, 2020
c49e84c
improve test names
timotheecour Dec 14, 2020
0faffdf
improve strutils.% error message
timotheecour Dec 14, 2020
b28520d
--lean flag to aggresively optimize for binary size
timotheecour Dec 15, 2020
7d453f0
fixup
timotheecour Dec 15, 2020
d61bfb4
fixup
timotheecour Dec 15, 2020
bfd69ba
fixup
timotheecour Jul 7, 2021
e760eb9
fix after rebase
timotheecour Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@timotheecour
timotheecour committed Jul 7, 2021
commit 7d453f0ba034c76fd235a0194fc6058e8c0ba059
7 changes: 6 additions & 1 deletion tests/stdlib/tstrutils.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,7 @@ bar
when not defined(js):
doAssert formatFloat(123.456, ffScientific, precision = -1) == "1.234560e+02"

block: # `addf`, `%`
block: # `%`
doAssert "$# $3 $# $#" % ["a", "b", "c"] == "a c b c"
doAssert "${1}12 ${-1}$2" % ["a", "b"] == "a12 bb"
doAssert "$animal eats $food." % ["animal", "The cat", "food", "fish"] ==
Expand All @@ -703,6 +703,11 @@ bar
doAssert e.msg == "invalid char '$' at index: '2' for input: 'a $key2 b'", e.msg
ok = true
doAssert ok

block: # addf
var a = "foo:"
a.addf("$# $3 $# $#", "a", "b", "c")
doAssert a == "foo:a c b c"

block: # formatSize
disableVm:
Expand Down