Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$ now works for unsigned intergers with nim js #14122

Merged

Conversation

timotheecour
Copy link
Member

No description provided.

@timotheecour timotheecour force-pushed the pr_fix_D20200425T141726_js_unsigned_dollar branch from 64a4c88 to 1edcdd9 Compare April 26, 2020 03:30
@timotheecour timotheecour force-pushed the pr_fix_D20200425T141726_js_unsigned_dollar branch from 1edcdd9 to 5d352b1 Compare April 26, 2020 03:34
@Araq
Copy link
Member

Araq commented Apr 26, 2020

This patch would be better without introducing your own ideas about how semver should work.

@timotheecour timotheecour force-pushed the pr_fix_D20200425T141726_js_unsigned_dollar branch from 55a6734 to c1a9357 Compare April 26, 2020 08:33
@timotheecour
Copy link
Member Author

timotheecour commented Apr 26, 2020

PTAL

This patch would be better without introducing your own ideas about how semver should work.

fine, I've reverted NimPatch bump from this PR, that aspect can be discussed separately in #14124

@narimiran
Copy link
Member

narimiran commented Apr 26, 2020

All changes in system.nim could be (and should be, IMO) reverted. They have nothing to do with the stuff this PR tries to fix.

EDIT: Ok, dollars need version info, but no need to move it 2000 lines above.

@timotheecour
Copy link
Member Author

timotheecour commented Apr 26, 2020

All changes in system.nim could be (and should be, IMO) reverted. They have nothing to do with the stuff this PR tries to fix.

"all changes" is litterally only moving the nim version tuple, and is a required change; the reason I had moved it to the top is that it's a commonly used symbol for versioning, and it makes sense to define it as early as possible, instead of having to move it each time. It already has to be separated from NimVersion anyways, so 2000 lines vs 4 lines makes only a cosmetic difference.

but I've now moved it right above system/dollars not far from Nimversion for the sake of moving on.

@Varriount Varriount force-pushed the pr_fix_D20200425T141726_js_unsigned_dollar branch from 065b2bd to c00dc52 Compare April 26, 2020 17:13
@Araq Araq merged commit a3a317b into nim-lang:devel Apr 27, 2020
@timotheecour timotheecour deleted the pr_fix_D20200425T141726_js_unsigned_dollar branch April 27, 2020 23:09
EchoPouet pushed a commit to EchoPouet/Nim that referenced this pull request Jun 13, 2020
* $(unsigned) now works for js
* move NimMajor+friends closer to NimVersion according as per reviewer feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants