-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$
now works for unsigned intergers with nim js
#14122
$
now works for unsigned intergers with nim js
#14122
Conversation
64a4c88
to
1edcdd9
Compare
1edcdd9
to
5d352b1
Compare
This patch would be better without introducing your own ideas about how semver should work. |
55a6734
to
c1a9357
Compare
PTAL
fine, I've reverted NimPatch bump from this PR, that aspect can be discussed separately in #14124 |
All changes in EDIT: Ok, |
"all changes" is litterally only moving the nim version tuple, and is a required change; the reason I had moved it to the top is that it's a commonly used symbol for versioning, and it makes sense to define it as early as possible, instead of having to move it each time. It already has to be separated from NimVersion anyways, so 2000 lines vs 4 lines makes only a cosmetic difference. but I've now moved it right above system/dollars not far from Nimversion for the sake of moving on. |
065b2bd
to
c00dc52
Compare
* $(unsigned) now works for js * move NimMajor+friends closer to NimVersion according as per reviewer feedback
No description provided.