Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koch --nim:pathto/nim boot and koch boot --hint:cc:off now work #13516

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Feb 27, 2020

  • koch boot --hint:cc:off now works (previously silently ignored that option)
    hintCC (the CC: passaux.nim lines etc) are very verbose so it's important that user should be able to disable these.
  • koch --nim:pathto/nim boot now works (previsouly silently ignored that option)
  • code cleanup to avoid duplications in affected code
# will honor --hint:cc:off or --hint:processing:off or any other flag in user configs
./koch boot -d:release --skipUserCfg:off
# other example that now works:
./koch --nim:pathto/nim boot -d:release -d:nimUseLinenoise --hint:cc:off
sh build_all.sh --skipUserCfg:off --hint:cc:off # for example

@Araq
Copy link
Member

Araq commented Feb 28, 2020

Now, in combination with #13488 and this PR, we can have a perfect workaround for #13411 (isolate the build process from external configuration files) if we allow build_all.sh to forward arguments to the koch build commands:

Yeah but the point of build_all.sh is that you don't have to know about these details.

@Araq Araq merged commit e64f1c7 into nim-lang:devel Mar 10, 2020
@timotheecour timotheecour deleted the pr_koch_boot_hints_nim branch March 11, 2020 00:57
@timotheecour
Copy link
Member Author

thanks for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants