Add more JS stuff to dom.nim

[treeform]

• LocalStorage
• activeElement
• innerText
• some Style properties.

[treeform]

Let's hope BSD test will not fail for some intermittent reason again related to io selectors.

[timotheecour]

Let's hope BSD test will not fail for some intermittent reason again related to io selectors.

you can simply rebase, I fixed the CI build.sh failure in https://github.com/nim-lang/Nim/pull/13564/files

pkg: wrong architecture: FreeBSD:12.0:amd64 instead of FreeBSD:12:amd64

[treeform]

Ok rebased and all tests pass.

[treeform]

I think have made the requested changes. Please take a look again when you can.

[timotheecour]

• great, LGTM. subsequent PRs could add doc links for other procs (eg https://developer.mozilla.org/en-US/docs/Web/API/Performance/now)
• @dom96 I see you often use the "change requested" github feature (in other PRs) but IMO that's overkill, as it often stays forever in that state even long after the contributor has addressed the issue (and contributor has no way to undo that state, only you can). IMO the following is 100% sufficient assuming no abuse:
  • reviewer writes a comment
  • contributor replies, and, using best judgement, marks as resolved if comment is fully addressed
  • unless reviewer disagrees and un-resolves that comment, that's the end of the story

[dom96]

@timotheecour huh? Where do you see that state reported? I am asking for changes, so I select "Changes Requested", I don't see how that negatively affects the PRs.

[dom96]

LGTM