Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only enable linenoise for -d:nimUseLinenoise #13478

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Feb 24, 2020

  • refs: 2b368bc#commitcomment-37273026
  • supersedes [superseded] niminst: make linenoise.h optional #13413
  • comments out copySrc(libpath / "lib/wrappers/linenoise/linenoise.h") from niminst since this was causing issues
  • users who need linenoise support now can't do it from a nim release (sadly...) but they can do it from a locally built nim by passing -d:nimUseLinenoise when building nim, eg via either:
  • ./koch boot -d:release -d:nimUseLinenoise
  • nim c -o:bin/nim_temp -d:release -d:nimUseLinenoise --lib:lib compiler/nim.nim

I've renamed -d:useLinenoise (which wasn't used since a few commits ago) to -d:nimUseLinenoise to adhere to namespace prefix rule but -d:useLinenoise will continue to work for backward compatibility

future PR's could consider something like: -d:useLinenoise:path/to/linenoise_header so that it could work for a nim release too, pointing to an external path

@Clyybber Clyybber merged commit 1cf5c28 into nim-lang:devel Feb 24, 2020
@timotheecour timotheecour deleted the pr_linenoise_optional branch February 24, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants