only enable linenoise for -d:nimUseLinenoise #13478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copySrc(libpath / "lib/wrappers/linenoise/linenoise.h")
from niminst since this was causing issues-d:nimUseLinenoise
when building nim, eg via either:I've renamed -d:useLinenoise (which wasn't used since a few commits ago) to
-d:nimUseLinenoise
to adhere to namespace prefix rule but -d:useLinenoise will continue to work for backward compatibilityfuture PR's could consider something like:
-d:useLinenoise:path/to/linenoise_header
so that it could work for a nim release too, pointing to an external path