Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] -d:danger should imply -d:release #13336

Merged
merged 1 commit into from
Feb 5, 2020
Merged

[backport] -d:danger should imply -d:release #13336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/nim.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ path="$lib/pure"
debugger:off
line_dir:off
opt:speed
define:release
@end

@if false: # not danger: # this does not work yet.
Expand Down
13 changes: 13 additions & 0 deletions tests/misc/tdangerisrelease.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
discard """
cmd: "nim c -d:danger -r $file"
output: '''
a
b
c
'''
"""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could've been simply:
doAssert defined(release)

echo "a"
when defined(release):
echo "b"
echo "c"