Skip to content

fix db_mysql getRow() when column is null error raised #12806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Araq merged 5 commits into from
Dec 5, 2019
Merged

fix db_mysql getRow() when column is null error raised #12806

Araq merged 5 commits into from
Dec 5, 2019

Conversation

@itsumura-h
Copy link
Contributor

@itsumura-h itsumura-h commented Dec 4, 2019 •
edited
Loading

If we have following users table in mysql and "email" column have null data

id name email
1 John null 
echo db.getRow(sql"SELECT * FROM users")

expects

@["1", "John", ""]

However we get an error

/nim/lib/impure/db_mysql.nim(310) getRow
SIGSEGV: Illegal storage access. (Attempt to read from nil?)

@itsumura-h
fix db_mysql getRow()
d831806 
add(result[i], row[i]) => add(result[i], $row[i])
@itsumura-h itsumura-h marked this pull request as ready for review December 4, 2019 07:52
@itsumura-h itsumura-h changed the title fix db_mysql getRow() fix db_mysql getRow() when column is null error raised Dec 4, 2019
@Araq
Copy link
Member

Araq commented Dec 4, 2019 •
edited
Loading

This is not good for performance, better fix add(s: string; x: cstring) to deal with x == nil. Around line 3413 in system.nim.

@itsumura-h
Copy link
Contributor Author

itsumura-h commented Dec 5, 2019

@Araq
It may works as expected!

@Araq
Copy link
Member

Araq commented Dec 5, 2019

This commit needs the [backport] tag.

@itsumura-h
Copy link
Contributor Author

itsumura-h commented Dec 5, 2019 •
edited
Loading

@Araq
Is it rignt?

d313055

@Araq Araq merged commit 208b018 into nim-lang:devel Dec 5, 2019
narimiran pushed a commit to narimiran/Nim that referenced this pull request Dec 10, 2019
@itsumura-h @narimiran
fix db_mysql getRow() when column is null error raised (nim-lang#12806)…
340c924 
… [backport]

* fix db_mysql getRow()
* added if y == nil [backport]

(cherry picked from commit 208b018)
This was referenced Jun 24, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@itsumura-h @Araq