Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very basic code fails from generic alias replacing concrete typedesc argument #23977

Closed
metagn opened this issue Aug 19, 2024 · 2 comments · Fixed by #23978
Closed

Very basic code fails from generic alias replacing concrete typedesc argument #23977

metagn opened this issue Aug 19, 2024 · 2 comments · Fixed by #23978
Labels
Generics

Comments

@metagn
Copy link
Collaborator

metagn commented Aug 19, 2024

Description

This test code is so simple I would think there has to be an issue for it but I couldn't find one. Even if there is I feel like this would have to be fixed with higher priority.

type Foo[T] = int

proc foo(T: typedesc) =
  var a: T

foo(int)

Even happens if Foo is defined in another module.

Nim Version

2e4d344 and 2.0.8 going back at least to 1.0

Current Output

(6, 4) template/generic instantiation of `foo` from here
(4, 7) Error: invalid type: 'Foo' for var

Expected Output

compiles

Possible Solution

No response

Additional Information

No response
@metagn metagn mentioned this issue Aug 19, 2024
Merged
@juancarlospaco
Copy link
Collaborator

!nim c

type Foo[T] = int

proc foo(T: typedesc) =
  var a: T

foo(int)

@github-actions GitHub Actions
Copy link
Contributor

🐧 Linux bisect by @juancarlospaco (collaborator)
devel 👎 FAIL

Output

Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
/home/runner/work/Nim/Nim/temp.nim(4, 4) template/generic instantiation of `foo` from here
/home/runner/work/Nim/Nim/temp.nim(3, 7) Error: invalid type: 'Foo' for var
assertions.nim(34)       raiseAssert
Error: unhandled exception: errGenerated [AssertionDefect]

IR

Compiled filesize 0 (0 bytes) 


Stats
    

  • Started	2024-08-19T13:45:31

  • Finished	2024-08-19T13:45:32

  • Duration	


AST


nnkStmtList.newTree(
  nnkTypeSection.newTree(
    nnkTypeDef.newTree(
      newIdentNode("Foo"),
      nnkGenericParams.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("T"),
          newEmptyNode(),
          newEmptyNode()
        )
      ),
      newIdentNode("int")
    )
  ),
  nnkProcDef.newTree(
    newIdentNode("foo"),
    newEmptyNode(),
    newEmptyNode(),
    nnkFormalParams.newTree(
      newEmptyNode(),
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newIdentNode("typedesc"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      nnkVarSection.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("a"),
          newIdentNode("T"),
          newEmptyNode()
        )
      )
    )
  ),
  nnkCall.newTree(
    newIdentNode("foo"),
    newIdentNode("int")
  )
)




stable	👎 FAIL
Output


Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
/home/runner/work/Nim/Nim/temp.nim(4, 4) template/generic instantiation of `foo` from here
/home/runner/work/Nim/Nim/temp.nim(3, 7) Error: invalid type: 'Foo' for var
assertions.nim(34)       raiseAssert
Error: unhandled exception: options.nim(682, 5) `false` errGenerated [AssertionDefect]



IR
Compiled filesize	0 (0 bytes)



Stats
    

  • Started	2024-08-19T13:45:35

  • Finished	2024-08-19T13:45:35

  • Duration	


AST


nnkStmtList.newTree(
  nnkTypeSection.newTree(
    nnkTypeDef.newTree(
      newIdentNode("Foo"),
      nnkGenericParams.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("T"),
          newEmptyNode(),
          newEmptyNode()
        )
      ),
      newIdentNode("int")
    )
  ),
  nnkProcDef.newTree(
    newIdentNode("foo"),
    newEmptyNode(),
    newEmptyNode(),
    nnkFormalParams.newTree(
      newEmptyNode(),
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newIdentNode("typedesc"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      nnkVarSection.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("a"),
          newIdentNode("T"),
          newEmptyNode()
        )
      )
    )
  ),
  nnkCall.newTree(
    newIdentNode("foo"),
    newIdentNode("int")
  )
)




2.0.4	👎 FAIL
Output


Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
/home/runner/work/Nim/Nim/temp.nim(4, 4) template/generic instantiation of `foo` from here
/home/runner/work/Nim/Nim/temp.nim(3, 7) Error: invalid type: 'Foo' for var
assertions.nim(34)       raiseAssert
Error: unhandled exception: options.nim(681, 5) `false` errGenerated [AssertionDefect]



IR
Compiled filesize	0 (0 bytes)



Stats
    

  • Started	2024-08-19T13:45:39

  • Finished	2024-08-19T13:45:39

  • Duration	


AST


nnkStmtList.newTree(
  nnkTypeSection.newTree(
    nnkTypeDef.newTree(
      newIdentNode("Foo"),
      nnkGenericParams.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("T"),
          newEmptyNode(),
          newEmptyNode()
        )
      ),
      newIdentNode("int")
    )
  ),
  nnkProcDef.newTree(
    newIdentNode("foo"),
    newEmptyNode(),
    newEmptyNode(),
    nnkFormalParams.newTree(
      newEmptyNode(),
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newIdentNode("typedesc"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      nnkVarSection.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("a"),
          newIdentNode("T"),
          newEmptyNode()
        )
      )
    )
  ),
  nnkCall.newTree(
    newIdentNode("foo"),
    newIdentNode("int")
  )
)




2.0.0	👎 FAIL
Output


Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
/home/runner/work/Nim/Nim/temp.nim(4, 4) template/generic instantiation of `foo` from here
/home/runner/work/Nim/Nim/temp.nim(3, 7) Error: invalid type: 'Foo' for var
assertions.nim(34)       raiseAssert
Error: unhandled exception: options.nim(664, 5) `false` errGenerated [AssertionDefect]



IR
Compiled filesize	0 (0 bytes)



Stats
    

  • Started	2024-08-19T13:45:42

  • Finished	2024-08-19T13:45:42

  • Duration	


AST


nnkStmtList.newTree(
  nnkTypeSection.newTree(
    nnkTypeDef.newTree(
      newIdentNode("Foo"),
      nnkGenericParams.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("T"),
          newEmptyNode(),
          newEmptyNode()
        )
      ),
      newIdentNode("int")
    )
  ),
  nnkProcDef.newTree(
    newIdentNode("foo"),
    newEmptyNode(),
    newEmptyNode(),
    nnkFormalParams.newTree(
      newEmptyNode(),
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newIdentNode("typedesc"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      nnkVarSection.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("a"),
          newIdentNode("T"),
          newEmptyNode()
        )
      )
    )
  ),
  nnkCall.newTree(
    newIdentNode("foo"),
    newIdentNode("int")
  )
)




1.6.20	👎 FAIL
Output


Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
/home/runner/work/Nim/Nim/temp.nim(4, 4) template/generic instantiation of `foo` from here
/home/runner/work/Nim/Nim/temp.nim(3, 7) Error: invalid type: 'Foo' for var
fatal.nim(54)            sysFatal
Error: unhandled exception: options.nim(662, 14) `false` errGenerated [AssertionDefect]



IR
Compiled filesize	0 (0 bytes)



Stats
    

  • Started	2024-08-19T13:45:44

  • Finished	2024-08-19T13:45:45

  • Duration	


AST


nnkStmtList.newTree(
  nnkTypeSection.newTree(
    nnkTypeDef.newTree(
      newIdentNode("Foo"),
      nnkGenericParams.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("T"),
          newEmptyNode(),
          newEmptyNode()
        )
      ),
      newIdentNode("int")
    )
  ),
  nnkProcDef.newTree(
    newIdentNode("foo"),
    newEmptyNode(),
    newEmptyNode(),
    nnkFormalParams.newTree(
      newEmptyNode(),
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newIdentNode("typedesc"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      nnkVarSection.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("a"),
          newIdentNode("T"),
          newEmptyNode()
        )
      )
    )
  ),
  nnkCall.newTree(
    newIdentNode("foo"),
    newIdentNode("int")
  )
)




1.4.8	👎 FAIL
Output


Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
/home/runner/work/Nim/Nim/temp.nim(4, 4) template/generic instantiation of `foo` from here
/home/runner/work/Nim/Nim/temp.nim(3, 7) Error: invalid type: 'Foo' for var



IR
Compiled filesize	0 (0 bytes)



Stats
    

  • Started	2024-08-19T13:45:47

  • Finished	2024-08-19T13:45:47

  • Duration	


AST


nnkStmtList.newTree(
  nnkTypeSection.newTree(
    nnkTypeDef.newTree(
      newIdentNode("Foo"),
      nnkGenericParams.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("T"),
          newEmptyNode(),
          newEmptyNode()
        )
      ),
      newIdentNode("int")
    )
  ),
  nnkProcDef.newTree(
    newIdentNode("foo"),
    newEmptyNode(),
    newEmptyNode(),
    nnkFormalParams.newTree(
      newEmptyNode(),
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newIdentNode("typedesc"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      nnkVarSection.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("a"),
          newIdentNode("T"),
          newEmptyNode()
        )
      )
    )
  ),
  nnkCall.newTree(
    newIdentNode("foo"),
    newIdentNode("int")
  )
)




1.2.18	👎 FAIL
Output


Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
/home/runner/work/Nim/Nim/temp.nim(4, 4) template/generic instantiation of `foo` from here
/home/runner/work/Nim/Nim/temp.nim(3, 7) Error: invalid type: 'Foo' for var



IR
Compiled filesize	0 (0 bytes)



Stats
    

  • Started	2024-08-19T13:45:49

  • Finished	2024-08-19T13:45:50

  • Duration	


AST


nnkStmtList.newTree(
  nnkTypeSection.newTree(
    nnkTypeDef.newTree(
      newIdentNode("Foo"),
      nnkGenericParams.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("T"),
          newEmptyNode(),
          newEmptyNode()
        )
      ),
      newIdentNode("int")
    )
  ),
  nnkProcDef.newTree(
    newIdentNode("foo"),
    newEmptyNode(),
    newEmptyNode(),
    nnkFormalParams.newTree(
      newEmptyNode(),
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newIdentNode("typedesc"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      nnkVarSection.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("a"),
          newIdentNode("T"),
          newEmptyNode()
        )
      )
    )
  ),
  nnkCall.newTree(
    newIdentNode("foo"),
    newIdentNode("int")
  )
)




1.0.10	👎 FAIL
Output


Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
/home/runner/work/Nim/Nim/temp.nim(4, 4) template/generic instantiation of `foo` from here
/home/runner/work/Nim/Nim/temp.nim(3, 7) Error: invalid type: 'Foo' for var



IR
Compiled filesize	0 (0 bytes)



Stats
    

  • Started	2024-08-19T13:45:52

  • Finished	2024-08-19T13:45:52

  • Duration	


AST


nnkStmtList.newTree(
  nnkTypeSection.newTree(
    nnkTypeDef.newTree(
      newIdentNode("Foo"),
      nnkGenericParams.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("T"),
          newEmptyNode(),
          newEmptyNode()
        )
      ),
      newIdentNode("int")
    )
  ),
  nnkProcDef.newTree(
    newIdentNode("foo"),
    newEmptyNode(),
    newEmptyNode(),
    nnkFormalParams.newTree(
      newEmptyNode(),
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newIdentNode("typedesc"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      nnkVarSection.newTree(
        nnkIdentDefs.newTree(
          newIdentNode("a"),
          newIdentNode("T"),
          newEmptyNode()
        )
      )
    )
  ),
  nnkCall.newTree(
    newIdentNode("foo"),
    newIdentNode("int")
  )
)




Stats
    

  • GCC	11.4.0

  • Clang	14.0.0

  • NodeJS	20.4

  • Created	2024-08-19T13:45:04Z

  • Comments	1

  • Commands	nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim


🤖 Bug found in 23 minutes bisecting 8 commits at 0 commits per second

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    


    

    

      
    

    


      

          @Araq
Araq




            closed this as completed
  in
    
      58813a3
    


      Aug 20, 2024

    

  


    


  
  


  
    
  
  

    
  narimiran 

      pushed a commit
      that referenced
      this issue

    
      Sep 13, 2024
    
    

      


  

    

      


  

      
        @metagn
      
        @narimiran
  





      

        
          make all generic aliases tyAlias (#23978)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          a78834c
        
      

    

  

    

      
fixes #23977

The problem is that for *any* body of a generic declaration,
[semstmts](https://github.com/nim-lang/Nim/blob/2e4d344b43b040a4dce2c478ca13e49979e491fc/compiler/semstmts.nim#L1610-L1611)
sets the sym of its value to the generic type name, and
[semtypes](https://github.com/nim-lang/Nim/blob/2e4d344b43b040a4dce2c478ca13e49979e491fc/compiler/semtypes.nim#L2143)
just directly gives the referenced type *specifically* when the
expression is a generic body. I'm blaming `semtypes` here because it's
responsible for the type given but the exact opposite behavior
specifically written in makes me think generating an alias type here
maybe breaks something.

(cherry picked from commit 58813a3)

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    Generics









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




            
Successfully merging a pull request may close this issue.





    


  
          
      make all generic aliases tyAlias

    
      metagn/Nim
    





    
  




        
      

    

  
      

  

    

      2 participants
    

    

        
          @juancarlospaco 
        
          @metagn