httpclient import causes compiler error with taint mode

[MatthewScholefield]

When importing httpclient when taint mode is enabled, compilation fails

Example

echo "import httpclient" > foo.nim
nim c --taintMode:on foo.nim

Current Output

nim-1.0.2/lib/pure/httpclient.nim(357, 6) Error: type mismatch: got <MultipartData, string, TaintedString, string, string>
but expected one of: 
proc add(p: var MultipartData; name, content: string; filename: string = "";
        contentType: string = "")
  first type mismatch at position: 3
  required type for content: string
  but expression 'readFile(file)' is of type: TaintedString
proc add(p: var MultipartData; xs: MultipartEntries): MultipartData
  first type mismatch at position: 2
  required type for xs: MultipartEntries
  but expression 'name' is of type: string
12 other mismatching symbols have been suppressed; compile with --showAllMismatches:on to see them

expression: add(p, name, readFile(file), fName & ext, contentType)

Expected Output

[Valid compilation]

Possible Solution

httpclient needs to resolve tainted strings properly

Additional Information

$ nim -v
Nim Compiler Version 1.0.2 [Linux: amd64]
Compiled at 2019-10-22
Copyright (c) 2006-2019 by Andreas Rumpf

git hash: 193b3c66bbeffafaebff166d24b9866f1eaaac0e
active boot switches: -d:release

[genotrance]

This is broken in 1.0.6 but fixed in devel. Backport? @narimiran

[narimiran]

This is broken in 1.0.6 but fixed in devel. Backport?

Sorry for the late response. It is this PR that fixed it in devel: #12969. I think we can backport it, so it becomes part of 1.0.8.