FreeBSD & OpenBSD: tests/stdlib/tgetaddrinfo fails

[euantorano]

Running tests on FreeBSD results in the following failure:

Category: stdlib
Name: tests/stdlib/tgetaddrinfo.nim C
Action: run
Result: reExitcodesDiffer
-------- Expected -------
exitcode: 0
--------- Given  --------
exitcode: 1

Output:
tgetaddrinfo.nim(22)     tgetaddrinfo
nativesockets.nim(262)   getAddrInfo
oserr.nim(94)            raiseOSError
Error: unhandled exception: Additional info: "servname not supported for ai_socktype" [OSError]
-------------------------

---

Running tests on OpenBSD results in the following failure:

Category: stdlib
Name: tests/stdlib/tgetaddrinfo.nim C
Action: run
Result: reExitcodesDiffer
-------- Expected -------
exitcode: 0
--------- Given  --------
exitcode: 1

Output:
tgetaddrinfo.nim(22)     tgetaddrinfo
nativesockets.nim(262)   getAddrInfo
oserr.nim(94)            raiseOSError
Error: unhandled exception: Additional info: "service not supported for ai_socktype" [OSError]
-------------------------

[alaviss]

I guess this block is linux-only?

Nim/tests/stdlib/tgetaddrinfo.nim

Lines 18 to 36 in 1396006

	when defined(posix) and not defined(haiku):
	block RAW_ICMP:
	# the port will be ignored
	let aiList = getAddrInfo("127.0.0.1", 999.Port, AF_INET, SOCK_RAW, IPPROTO_ICMP)
	doAssert aiList != nil
	doAssert aiList.ai_addr != nil
	doAssert aiList.ai_addrlen.SockLen == sizeof(Sockaddr_in).SockLen
	doAssert aiList.ai_next == nil
	freeAddrInfo aiList
	block RAW_ICMPV6:
	# the port will be ignored
	let aiList = getAddrInfo("::1", 999.Port, AF_INET6, SOCK_RAW, IPPROTO_ICMPV6)
	doAssert aiList != nil
	doAssert aiList.ai_addr != nil
	doAssert aiList.ai_addrlen.SockLen == sizeof(Sockaddr_in6).SockLen
	doAssert aiList.ai_next == nil
	freeAddrInfo aiList

[euantorano]

The current test runs on all POSIX systems, except Haiku. In my FreeBSD PR I disable the test for FreeBSD: https://github.com/nim-lang/Nim/blob/5e96ca4340f03ae8f76ae39331c60e4e269f4ce7/tests/stdlib/tgetaddrinfo.nim#L18 I do the same in my OpenBSD PR: https://github.com/nim-lang/Nim/blob/e3645a9e9fedc3220f9b12e6a188e2cfebe82418/tests/stdlib/tgetaddrinfo.nim#L18 It may make sense to change the code so that it does only run on Linux.

…

On Tue, 24 Sep 2019, at 05:16, alaviss wrote: I guess this block is linux-only? https://github.com/nim-lang/Nim/blob/13960066cbc376849288792bc20599396a03a0a9/tests/stdlib/tgetaddrinfo.nim#L18-L36 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12181?email_source=notifications&email_token=AAFW24OVXHTU3RU5RNUR7KLQLGIBRA5CNFSM4IVY6VGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7NADYA#issuecomment-534381024>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFW24K2F6WYMDZJ5CCDM5LQLGIBRANCNFSM4IVY6VGA>.

[euantorano]

I'm closing this issue after having looked at source for the getaddrinfo() function in FreeBSD, OpenBSD and NetBSD. It seems that they intentionally don't support this.

• FreeBSD
• OpenBSD
• NetBSD