Invalid CHMOD in `tests/async/tioselectors`

[euantorano]

The test async/tioselectors contains the following code:

# chmod testDirectory to 0777
chmodPath(testDirectory, 0x1FF)

0x1FF is 511 decimal and it seems that's what's passed in to posix.chmod, resulting in the following test failure on OpenBSD:

FAIL: tests/async/tioselectors.nim C
Test "tests/async/tioselectors.nim" in category "async"
Failure: reExitcodesDiffer
Expected:
exitcode: 0
Gotten:
mexitcode: 1

Output:
tioselectors.nim(471)    tioselectors
tioselectors.nim(324)    vnode_test
tioselectors.nim(264)    chmodPath
fatal.nim(48)            sysFatal
Error: unhandled exception: value out of range: 511 [RangeError]

I'm not sure if I should just change the code to pass 777? If so, there's at least one other place in the same tets that seems suspicious: https://github.com/nim-lang/Nim/blob/devel/tests/async/tioselectors.nim#L381

[cheatfate]

Its very weird, because 0777 is octal number which is equal to 511 decimal number which is equal to 0x1FF hexadecimal number.

Same weird problem with 0666 is octal number which is equal to 438 decimal number which is equal to 0x1B6 hexadecimal number.

[euantorano]

Check the constant values defined here: http://man7.org/linux/man-pages/man2/chmod.2.html (for example `S_IRGRP (00040)`). Are we sure that `posix.chmod` is meant to take the octal values and not just standard decimal values?

…

On Tue, 3 Sep 2019, at 23:09, Eugene Kabanov wrote: Its very weird, because `0777` is octal number which is equal to `511` decimal number which is equal to `0x1FF` hexadecimal number. Same weird problem with `0666` is octal number which is equal to `438` decimal number which is equal to `0x1B6` hexadecimal number. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12119?email_source=notifications&email_token=AAFW24OBBK6LCCVZSPG3YVTQH3OA5A5CNFSM4ITHZ2LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5ZXIYI#issuecomment-527660129>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFW24ME2OWB6GCQIM2CXRTQH3OA5ANCNFSM4ITHZ2LA>.

[euantorano]

I've just tested on linux and the hex number works as expected there. I'm about to test on FreeBSD then OpenBSD.

[euantorano]

Ok, so running the following code on OpenBSD runs fine:

import posix, os

const dir_path = "./test_dir"

discard existsOrCreateDir(dir_path)

var info = getFileInfo(dir_path)

echo "Permissions before: ", info.permissions

let err = posix.chmod(dir_path, Mode(0x1FF))
if err == -1:
  raiseOsError(osLastError())

info = getFileInfo(dir_path)

echo "Permissions after: ", info.permissions

I get the following output:

Permissions before: {fpUserExec, fpUserWrite, fpUserRead, fpGroupExec, fpGroupRead, fpOthersExec, fpOthersRead}
Permissions after: {fpUserExec, fpUserWrite, fpUserRead, fpGroupExec, fpGroupWrite, fpGroupRead, fpOthersExec, fpOthersWrite, fpOthersRead}

Which is correct.

However

If I change the script to:

import posix, os

proc chmodPath(name: string, mode: cint) =
  let err = posix.chmod(cstring(name), Mode(mode))
  if err == -1:
    raiseOsError(osLastError())


const dir_path = "./test_dir"

discard existsOrCreateDir(dir_path)

var info = getFileInfo(dir_path)

echo "Permissions before: ", info.permissions

chmodPath(dir_path, 0x1FF)

info = getFileInfo(dir_path)

echo "Permissions after: ", info.permissions

I get the error:

Permissions before: {fpUserExec, fpUserWrite, fpUserRead, fpGroupExec, fpGroupWrite, fpGroupRead, fpOthersExec, fpOthersWrite, fpOthersRead}
/home/administrator/test/test.nim(17) test
/home/administrator/test/test.nim(4) chmodPath
/home/administrator/build/Nim/lib/system/fatal.nim(48) sysFatal
Error: unhandled exception: value out of range: 511 [RangeError]
Error: execution of an external program failed: '/home/administrator/test/test '

Which is... interesting 😄

[euantorano]

The following snippet also crashes with the same error on both OpenBSD and Linux (including the playground):

import posix

let m1: int = 0x1FF
let m2: cint = 0x1FF

echo Mode(m1)
echo Mode(m2)

However, changing it to:

import posix

let m1: int32 = 0x1FF
let m2: cint = 0x1FF

echo Mode(m1)
echo Mode(m2)

Works, so it seems to be a problem with the implicit cast from an int to cint on 64 bit systems or something?