Koch bootCI error on FreeBSD

[euantorano]

When running koch runCI on FreeBSD, the following error is reported:

[build@build /usr/home/build/Nim]$ ./koch runCI
runCI:
'/usr/home/build/Nim/koch' boot
sh: Syntax error: Unterminated quoted string
FAILURE

When running echo $SHELL, the shell is /usr/local/bin/bash.

Running '/usr/home/build/Nim/koch' boot from the shell works correctly.

[euantorano]

This may be related to quoteShellPosix - reading that code, /usr/home/build/Nim/koch shouldn't be quoted at all as all of the characters in that path are in the set of safe characters aren't they?

[awr1]

We should detect which shell is the default shell when running CI (I assume some technicality w/ sh on FreeBSD is causing this?) and adjust accordingly. Either that or just launch bash in the script.

[euantorano]

It looks like part of the problem here is that kochExe has a null (\0) terminator in FreeBSD which causes it to be quoted even when in a safe path, so now I'm trying to figure out the cause for that...

[euantorano]

This is fixed by 16fc1de.