-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins: initial support of parallel execution #58
Conversation
57e7c56
to
7dad4fe
Compare
@milton0825 - I think this branch is pretty close to done (aside from full integration tests with a plugin written in another language.. I may give that a shot and add it to the Anyway, if you could give this a look and if possible run through the tests and/or try out a plugin that would be hugely helpful. I'll move on to your other PR in the meantime. Thanks again! /cc @november-yankee, @rwong, @celrenheit (if you're also interested in taking a look!) |
d55c3c0
to
78a2980
Compare
@nilslice this is awesome! I can try build a plugin and share my experience back. It may take a few days to get back to you tho |
I just tested it with my plugin and it works well. Great work! |
} | ||
} | ||
|
||
var _ Plugin = &plugin{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious. what is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to do this sometimes to get an early compile-time (and often in IDEs) error that is only resolved if type plugin struct
fully implements type Plugin interface
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I see. good learning
1845a68
to
eeb0cf3
Compare
Thank you very much for testing! I will write up some documentation for this and try to find some time to add an example plugin in another language. Feel free to add any additional thoughts, concerns, issues, etc here. |
…dling from plugins
85ff968
to
270c047
Compare
597c847
to
2f0adb7
Compare
This branches off of #57.