Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: initial support of parallel execution #58

Merged
merged 20 commits into from
Nov 5, 2018

Conversation

nilslice
Copy link
Owner

This branches off of #57.

@nilslice nilslice force-pushed the sm/plugin-support-parallel branch 8 times, most recently from 57e7c56 to 7dad4fe Compare November 1, 2018 17:25
@nilslice
Copy link
Owner Author

nilslice commented Nov 1, 2018

@milton0825 - I think this branch is pretty close to done (aside from full integration tests with a plugin written in another language.. I may give that a shot and add it to the plugin-samples directory.

Anyway, if you could give this a look and if possible run through the tests and/or try out a plugin that would be hugely helpful.

I'll move on to your other PR in the meantime. Thanks again!


/cc @november-yankee, @rwong, @celrenheit (if you're also interested in taking a look!)

@nilslice nilslice force-pushed the sm/plugin-support-parallel branch from d55c3c0 to 78a2980 Compare November 1, 2018 19:55
@milton0825
Copy link
Contributor

milton0825 commented Nov 1, 2018

@nilslice this is awesome! I can try build a plugin and share my experience back. It may take a few days to get back to you tho

@milton0825
Copy link
Contributor

I just tested it with my plugin and it works well. Great work!

}
}

var _ Plugin = &plugin{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious. what is this for?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to do this sometimes to get an early compile-time (and often in IDEs) error that is only resolved if type plugin struct fully implements type Plugin interface.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see. good learning

@nilslice nilslice force-pushed the sm/plugin-support-parallel branch 2 times, most recently from 1845a68 to eeb0cf3 Compare November 2, 2018 06:40
@nilslice
Copy link
Owner Author

nilslice commented Nov 2, 2018

I just tested it with my plugin and it works well. Great work!

Thank you very much for testing!

I will write up some documentation for this and try to find some time to add an example plugin in another language. Feel free to add any additional thoughts, concerns, issues, etc here.

@milton0825
Copy link
Contributor

@nilslice nilslice force-pushed the sm/plugin-support-parallel branch from 85ff968 to 270c047 Compare November 4, 2018 03:36
@nilslice nilslice force-pushed the sm/plugin-support-parallel branch from 597c847 to 2f0adb7 Compare November 5, 2018 01:19
@nilslice nilslice merged commit d95c8fe into master Nov 5, 2018
@nilslice nilslice deleted the sm/plugin-support-parallel branch November 5, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants