Skip to content

False positive in camelCase naming violation for EnumValueOptions builtin #150

Open
@midsbie

Description

I've encountered an issue with protolock's handling of EnumValueOptions in Protobuf, which seems to be a false positive and might represent bug(s) in the tool.

Specifically, protolock is flagging a camel case naming violation for EnumValueOptions, a built-in Protobuf symbol (documentation). Given that this is a standard, predefined Protobuf entity, it should not be subject to camel case violation checks. This false positive is misleading and contradicts Protobuf's standard naming conventions.


Example:

syntax = "proto3";

import "google/protobuf/descriptor.proto";

package foo.v1;

extend google.protobuf.EnumValueOptions {
  string display_name = 10001;
}

Produces:

CONFLICT: Message google.protobuf.EnumValueOptions is not CamelCase (wih an initial capital)

Only way I found of "resolving" the error was to add a skip hint:

// @protolock:skip
extend google.protobuf.EnumValueOptions {
  ...

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions