Skip to content

Commit

Permalink
added .checkpoint method
Browse files Browse the repository at this point in the history
  • Loading branch information
Joshua Wise committed Sep 9, 2016
1 parent 81931f5 commit bce1561
Show file tree
Hide file tree
Showing 10 changed files with 146 additions and 33 deletions.
1 change: 1 addition & 0 deletions binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"src/objects/transaction/transaction.cc",
"src/workers/database-workers/open.cc",
"src/workers/database-workers/close.cc",
"src/workers/database-workers/checkpoint.cc",
"src/workers/statement-workers/run.cc",
"src/workers/statement-workers/get.cc",
"src/workers/statement-workers/all.cc",
Expand Down
27 changes: 27 additions & 0 deletions src/objects/database/checkpoint.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// .checkpoint([boolean force], Function callback) -> this

NAN_METHOD(Database::Checkpoint) {
bool force;
v8::Local<v8::Function> func;
if (info.Length() >= 2) {
TRUTHINESS_OF_ARGUMENT(0, a);
REQUIRE_ARGUMENT_FUNCTION(1, b);
force = a;
func = b;
} else {
force = false;
REQUIRE_ARGUMENT_FUNCTION(0, a);
func = a;
}

Database* db = Nan::ObjectWrap::Unwrap<Database>(info.This());
if (db->state != DB_READY) {
return Nan::ThrowError("The database connection is not open.");
}

db->Ref();
db->workers += 1;
Nan::AsyncQueueWorker(new CheckpointWorker(db, force, new Nan::Callback(func)));

info.GetReturnValue().Set(info.This());
}
3 changes: 3 additions & 0 deletions src/objects/database/database.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include "../transaction/transaction.h"
#include "../../workers/database-workers/open.h"
#include "../../workers/database-workers/close.h"
#include "../../workers/database-workers/checkpoint.h"
#include "../../util/macros.h"
#include "../../util/data.h"
#include "../../util/list.h"
Expand All @@ -22,6 +23,7 @@ sqlite3_uint64 NEXT_TRANSACTION_ID = 0;
#include "create-statement.cc"
#include "create-transaction.cc"
#include "pragma.cc"
#include "checkpoint.cc"

Database::Database() : Nan::ObjectWrap(),
read_handle(NULL),
Expand Down Expand Up @@ -55,6 +57,7 @@ NAN_MODULE_INIT(Database::Init) {
Nan::SetPrototypeMethod(t, "statement", CreateStatement);
Nan::SetPrototypeMethod(t, "transaction", CreateTransaction);
Nan::SetPrototypeMethod(t, "pragma", Pragma);
Nan::SetPrototypeMethod(t, "checkpoint", Checkpoint);
Nan::SetAccessor(t->InstanceTemplate(), Nan::New("open").ToLocalChecked(), Open);

Nan::Set(target, Nan::New("Database").ToLocalChecked(),
Expand Down
6 changes: 4 additions & 2 deletions src/objects/database/database.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@ class Database : public Nan::ObjectWrap {
static NAN_MODULE_INIT(Init);

// Friends
friend class OpenWorker;
friend class CloseWorker;
friend class Statement;
friend class Transaction;
friend class OpenWorker;
friend class CloseWorker;
friend class CheckpointWorker;
template <class OBJECT, class ASYNC> friend class QueryWorker;
friend class RunWorker;
friend class TransactionWorker;
Expand All @@ -37,6 +38,7 @@ class Database : public Nan::ObjectWrap {
static NAN_METHOD(CreateStatement);
static NAN_METHOD(CreateTransaction);
static NAN_METHOD(Pragma);
static NAN_METHOD(Checkpoint);
int CloseHandles();
void MaybeClose();

Expand Down
12 changes: 9 additions & 3 deletions src/objects/database/pragma.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ NAN_METHOD(Database::Pragma) {
// Executes the SQL on the read handle.
sqlite3_exec(db->read_handle, *utf8, NULL, NULL, &err);
if (err != NULL) {
Nan::ThrowError(err);
CONCAT2(message, "SQLite: ", err);
sqlite3_free(err);
Nan::ThrowError(message);
return;
}
sqlite3_free(err);
Expand All @@ -44,15 +45,20 @@ NAN_METHOD(Database::Pragma) {
List<Data::Row> table[2] {};
sqlite3_exec(db->write_handle, *utf8, PragmaCallback, table, &err);
if (err != NULL) {
Nan::ThrowError(err);
CONCAT2(message, "SQLite: ", err);
sqlite3_free(err);
Nan::ThrowError(message);
return;
}
sqlite3_free(err);

if (simple_result) {
Data::Row* values = table[1].Shift();
info.GetReturnValue().Set(values->values[0]->ToJS());
if (values == NULL) {
info.GetReturnValue().Set(Nan::Undefined());
} else {
info.GetReturnValue().Set(values->values[0]->ToJS());
}
delete values;
} else {
unsigned int i = 0;
Expand Down
55 changes: 55 additions & 0 deletions src/workers/database-workers/checkpoint.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
#include <sqlite3.h>
#include <nan.h>
#include "checkpoint.h"
#include "../../objects/database/database.h"
#include "../../util/macros.h"

CheckpointWorker::CheckpointWorker(Database* db, bool force, Nan::Callback* cb) : Nan::AsyncWorker(cb),
db(db),
force(force) {}
void CheckpointWorker::Execute() {
sqlite3* db_handle = db->write_handle;
LOCK_DB(db_handle);

int total_frames;
int checkpointed_frames;
int status = sqlite3_wal_checkpoint_v2(
db_handle,
"main",
force ? SQLITE_CHECKPOINT_RESTART : SQLITE_CHECKPOINT_PASSIVE,
&total_frames,
&checkpointed_frames
);

if (status == SQLITE_OK) {
if (checkpointed_frames < 0 || total_frames < 0) {
fraction_checkpointed = 0;
} else if (total_frames == 0) {
fraction_checkpointed = 1;
} else {
fraction_checkpointed = (double)checkpointed_frames / (double)total_frames;
}
} else {
SetErrorMessage(sqlite3_errmsg(db_handle));
}

UNLOCK_DB(db_handle);
}
void CheckpointWorker::HandleOKCallback() {
Nan::HandleScope scope;
if (--db->workers == 0) {db->Unref();}

v8::Local<v8::Value> args[2] = {
Nan::Null(),
Nan::New<v8::Number>(fraction_checkpointed)
};
Nan::AsyncWorker::callback->Call(2, args);
}
void CheckpointWorker::HandleErrorCallback() {
Nan::HandleScope scope;
if (--db->workers == 0) {db->Unref();}

CONCAT2(message, "SQLite: ", Nan::AsyncWorker::ErrorMessage());
v8::Local<v8::Value> args[1] = {Nan::Error(message)};
Nan::AsyncWorker::callback->Call(1, args);
}
19 changes: 19 additions & 0 deletions src/workers/database-workers/checkpoint.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#ifndef BETTER_SQLITE3_WORKER_CHECKPOINT_H
#define BETTER_SQLITE3_WORKER_CHECKPOINT_H

#include <nan.h>
class Database;

class CheckpointWorker : public Nan::AsyncWorker {
public:
CheckpointWorker(Database*, bool, Nan::Callback*);
void Execute();
void HandleOKCallback();
void HandleErrorCallback();
private:
Database* const db;
bool force;
double fraction_checkpointed;
};

#endif
38 changes: 19 additions & 19 deletions src/workers/database-workers/close.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,28 +18,28 @@ void CloseWorker::Execute() {
}
void CloseWorker::HandleOKCallback() {
Nan::HandleScope scope;
v8::Local<v8::Object> database = db->handle();
if (--db->workers == 0) {db->Unref();}
v8::Local<v8::Value> args[2] = {
NEW_INTERNAL_STRING_FAST("close"),
Nan::Null()
};
v8::Local<v8::Object> database = db->handle();
if (--db->workers == 0) {db->Unref();}
v8::Local<v8::Value> args[2] = {
NEW_INTERNAL_STRING_FAST("close"),
Nan::Null()
};
EMIT_EVENT(database, 2, args);
}
void CloseWorker::HandleErrorCallback() {
Nan::HandleScope scope;
v8::Local<v8::Object> database = db->handle();
if (--db->workers == 0) {db->Unref();}
CONCAT2(message, "SQLite: ", ErrorMessage());
v8::Local<v8::Value> args[2] = {
NEW_INTERNAL_STRING_FAST("close"),
Nan::Error(message)
};
v8::Local<v8::Object> database = db->handle();
if (--db->workers == 0) {db->Unref();}
CONCAT2(message, "SQLite: ", ErrorMessage());
v8::Local<v8::Value> args[2] = {
NEW_INTERNAL_STRING_FAST("close"),
Nan::Error(message)
};
EMIT_EVENT(database, 2, args);
}
16 changes: 8 additions & 8 deletions src/workers/database-workers/open.cc
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ void OpenWorker::Execute() {
}
void OpenWorker::HandleOKCallback() {
Nan::HandleScope scope;
v8::Local<v8::Object> database = db->handle();
if (--db->workers == 0) {db->Unref();}
v8::Local<v8::Object> database = db->handle();
if (--db->workers == 0) {db->Unref();}
if (db->state == DB_DONE) {
db->CloseHandles();
} else {
Expand All @@ -57,10 +57,10 @@ void OpenWorker::HandleOKCallback() {
}
void OpenWorker::HandleErrorCallback() {
Nan::HandleScope scope;
v8::Local<v8::Object> database = db->handle();
if (--db->workers == 0) {db->Unref();}
v8::Local<v8::Object> database = db->handle();
if (--db->workers == 0) {db->Unref();}
if (db->state != DB_DONE) {
db->state = DB_DONE;

Expand Down
2 changes: 1 addition & 1 deletion src/workers/database-workers/open.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class Database;

class OpenWorker : public Nan::AsyncWorker {
public:
OpenWorker(Database*, char*, bool);
OpenWorker(Database*, char*);
~OpenWorker();
void Execute();
void HandleOKCallback();
Expand Down

0 comments on commit bce1561

Please sign in to comment.