Linear gradients now parse color names #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usmonster
force-pushed
the
fix-firefox-gradients
branch
from
d450394 to
05fe609
Compare
Also: - Cleans up color stop and linear gradient regular expressions. - Handles percentage-based linear gradient positions (fixes Firefox). Fixes niklasvh#469.
usmonster
force-pushed
the
fix-firefox-gradients
branch
from
05fe609 to
318ca48
Compare
niklasvh
added a commit
that referenced
this pull request
Nov 9, 2015
Linear gradients now parse color names
|
Thanks for merging, @niklasvh! I compared the test logs before and after, and screenshot comparisons improved pretty much everywhere in terms of accuracy and performance... except for on Chrome: $ diff -u before.txt after.txt | grep COMPLETE | grep linear-gradient
- COMPLETE 4.112 seconds (64/66) firefox-15-Windows 7 /background/linear-gradient.html 76.78%
+ COMPLETE 2.356 seconds (64/66) firefox-15-Windows 7 /background/linear-gradient.html 89.16%
- COMPLETE 3.595 seconds (64/66) chrome-39-Windows 7 /background/linear-gradient.html 20.17%
+ COMPLETE 2.253 seconds (64/66) chrome-39-Windows 7 /background/linear-gradient.html 11.80%
- COMPLETE 2.766 seconds (64/66) internet explorer-9-Windows 7 /background/linear-gradient.html 100.00%
+ COMPLETE 2.814 seconds (64/66) internet explorer-9-Windows 7 /background/linear-gradient.html 100.00%
- COMPLETE 4.429 seconds (64/66) safari-7-OS X 10.9 /background/linear-gradient.html 65.13%
+ COMPLETE 3.575 seconds (64/66) safari-7-OS X 10.9 /background/linear-gradient.html 71.50%
- COMPLETE 4.438 seconds (64/66) safari-6-OS X 10.8 /background/linear-gradient.html 64.83%
+ COMPLETE 3.612 seconds (64/66) safari-6-OS X 10.8 /background/linear-gradient.html 70.79%
- COMPLETE 5.985 seconds (64/66) chrome-39-OS X 10.8 /background/linear-gradient.html 19.03%
+ COMPLETE 2.508 seconds (64/66) chrome-39-OS X 10.8 /background/linear-gradient.html 10.85%
- COMPLETE 4.275 seconds (64/66) internet explorer-11-Windows 8.1 /background/linear-gradient.html 74.14%
+ COMPLETE 3.611 seconds (64/66) internet explorer-11-Windows 8.1 /background/linear-gradient.html 85.42%
- COMPLETE 3.415 seconds (64/66) internet explorer-10-Windows 8 /background/linear-gradient.html 74.14%
+ COMPLETE 3.315 seconds (64/66) internet explorer-10-Windows 8 /background/linear-gradient.html 85.55%I'll have to investigate this later, but it may be a false alarm. |
|
Thanks for PR again @usmonster, sorry for the delay in getting it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Fixes #469.