Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform matrix for IE #545

Merged
merged 1 commit into from
Mar 7, 2015
Merged

Conversation

cornedor
Copy link
Contributor

@cornedor cornedor commented Mar 5, 2015

IE10+ returns a matrix3d instead of matrix. Changed the regex to also check for matrix3d and convert matrix3d to a 'normal' matrix

@niklasvh
Copy link
Owner

niklasvh commented Mar 7, 2015

All the test cases in tests/cases/transform/ return matrix for IE11, could you provide an example case where IE returns matrix3d where other browsers return matrix?

@cornedor
Copy link
Contributor Author

cornedor commented Mar 7, 2015

http://jsbin.com/bebuwugeru/1/edit
Will render to:
capture

EDIT: The test cases just use transform: rotate(); while in my case i used transform: rotateZ();

@niklasvh niklasvh closed this Mar 7, 2015
@niklasvh niklasvh reopened this Mar 7, 2015
niklasvh added a commit that referenced this pull request Mar 7, 2015
@niklasvh niklasvh merged commit 4b80102 into niklasvh:master Mar 7, 2015
@niklasvh
Copy link
Owner

niklasvh commented Mar 7, 2015

Thanks, merged!

@usmonster
Copy link
Contributor

Looks like this either breaks a test on Chrome, or the test is flaky:
https://travis-ci.org/niklasvh/html2canvas/builds/53498104#L865

(I'm thinking the latter, since it seems the connection was closed while the test was waiting for feedback..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants