This repository was archived by the owner on Jul 1, 2025. It is now read-only.
Cleaner buffer and reader (mostly) #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clean up buffer back to box move Read to Buffer Delete sample.pgn compile time `N` in ensure_bytes optimize, impl Read for Buffer add bench rename index to start and len to end rename discard_data to clear, doc fixes fix comment, import Range remove Buffer Read, back to Chained remove time taken from validate example remove benchmark not relevant fix `Buffer::into_inner` revert `BufferedReader::into_inner` add docs to `BufferedReader`, some clippy
tigerros
changed the title
This was referenced Jun 26, 2025
Contributor
Author
|
Moved to niklasf/shakmaty#105 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buffer.rs.BufferedReadermethods (they were deleted for some reason).ReadfromBufferedReadertobuffer.rs, preventing accidental usage elsewhere.Buffer::ensure_bytesnow backshifts only when necessary, not just ifbuffer.startis greater than 0.Bufferfields for clarity.debug_assertinBuffer::datathat reflects the safety comment.