Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-e --> -f #34

Merged
merged 1 commit into from
Oct 9, 2020
Merged

-e --> -f #34

merged 1 commit into from
Oct 9, 2020

Conversation

152334H
Copy link
Contributor

@152334H 152334H commented Sep 18, 2020

A lot of Bad Things happen if someone accidentally ./adds a directory (instead of a normal file):

$ ./add .
sha1sum: /path/to/A/libc-database: Is a directory
Adding local libc /path/to/A/libc-database (id local-)
  -> Writing libc /path/to/A/libc-database to db/local-.so
cp: -r not specified; omitting directory '/path/to/A/libc-database'
  -> Writing symbols to db/local-.symbols
readelf: Error: '/path/to/A/libc-database' is not an ordinary file
objdump: Warning: '/path/to/A/libc-database' is not an ordinary file
objdump: Warning: '/path/to/A/libc-database' is not an ordinary file
  -> Writing version info

-f will check for a regular file, instead of an arbitrary file (-e)

@niklasb niklasb merged commit d35f85c into niklasb:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants