Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app/automatic-dev-flow): move on changes requested #128

Merged
merged 1 commit into from
Mar 13, 2022

Conversation

pinussilvestrus
Copy link
Contributor

Related to https://github.com/bpmn-io/internal-docs/issues/451

This moves a pull request back to in progress once a review requested changes.

@nikku is there any way to unit test those dev flow handlers? Or should I set up a proper local environment? As for now I simply implemented it according to GitHub's API:

@nikku
Copy link
Owner

nikku commented Mar 1, 2022

No local tests for the time being. I usually integration test using a real world example.

Will review and get back to you.

@nikku nikku self-requested a review March 1, 2022 14:01
@nikku nikku merged commit c67f1ba into nikku:master Mar 13, 2022
@pinussilvestrus pinussilvestrus deleted the 451-move-rfc-to-progress branch March 15, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants