Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking Github number does search instead of opening issue #35

Closed
joannenolan-sky opened this issue Jul 15, 2019 · 6 comments
Closed

Comments

@joannenolan-sky
Copy link
Contributor

When I click on an issue number, instead of opening the Github issue as it did previously, a search is done on the issue instead.
Screen Shot 2019-07-15 at 11 06 15

@nikku
Copy link
Owner

nikku commented Jul 15, 2019

Is this a feature request or bug report?

You can navigate to the issue via the small GitHub icon or by using your standard browser controls (CTRL or CMD + click will the link in a new tab, bringing you to the GitHub page).

@joannenolan-sky
Copy link
Contributor Author

A Bug report, as this is a change to current behaviour. It also means I can't click on a link directly I can only search on that link. This is especially irritating if I have searched for an issue in the first place

@nikku
Copy link
Owner

nikku commented Jul 15, 2019

As mentioned above you can still click on the link just fine. Given that fact, how much of an issue is that for your?

The new interaction is intentional, as it allows you to very quickly drill down into individual issues, check their dependencies and so on. You may always drill up again via HISTORY BACK or the related keyboard shortcut.

@joannenolan-sky
Copy link
Contributor Author

I think it is useful to have that search feature on the icons as they are usually how you want to search but it is more steps if I want to click on a linked issue as that will only bring me to the search and not the issue itself.
For example on a childEpic Icon, instead of on the issue number., have it search using the icon

 <LinkIcon class="epic" name="epic" onClick={ onSelect && handleSelection('ref', item.key) }/>

@nikku nikku closed this as completed in 7c62a00 Jul 30, 2019
@nikku
Copy link
Owner

nikku commented Jul 30, 2019

I've heard this feedback on direct clicking from a number of places right now.

While I'm not a fan of silencing the default browser click + modifier behavior I'm also aware of the implications of not being able to navigate to GitHub easily for non-keyboard users.

7c62a00 reverts to the requested, old behavior. In order to filter the board, users must press CTRL (to apply filter) or SHIFT (add as filter criteria).

Happy to hear your thoughts on this change.

@nikku
Copy link
Owner

nikku commented Jul 30, 2019

Released as v0.20.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants