This repository was archived by the owner on Feb 15, 2023. It is now read-only.
Fixed memory leak in QHttpConnection class#64
Open
stefanmayer wants to merge 2 commits intonikhilm:masterfrom
Open
Fixed memory leak in QHttpConnection class#64stefanmayer wants to merge 2 commits intonikhilm:masterfrom
stefanmayer wants to merge 2 commits intonikhilm:masterfrom
Conversation
… object if the connection is destroyed)
…nection [BUGFIX] fixed memory leak in QHttpConnection class (delete m_request…
Owner
|
Thanks! Could you fix the indentation? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On each http request a new instance of
m_requestwas created and not deleted. So every request caused a memory gap of several kB.To close this gap the
m_requestinstance oftheConnectionis deleted if the connection is destoyed.