refactor(tui): theme switching & loading reactivity#3
Open
Conversation
fcad986 to
c975501
Compare
f41140c to
ee5703f
Compare
bb86c29 to
1606248
Compare
1606248 to
14712f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
systemcolors anomalyco/opencode#6322Refactor
Remodels theme resolution reactivity with respect to this tuple:
This change also prepares for a feature: system-like custom themes
Fixes
Performance
The theme context now readies 10x faster in by-far the most common case: using one of the default themes. The speedup is achieved by not waiting on resources irrelevant to the requested theme before marking it as ready.
Timed using this patch that calls
console.timeinsidecreateSimpleContext.After = 3.558ms
Before = 31.264ms
Implementation
createResourcescreateMemoreturning this tuple:createEffects